Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Portfolio
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      might be just as simple as require_cap in portfolio/add.php

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mjollnir Penny Leach added a comment -

              after discussion with MD the plan is to:

              • the calling code can check has_capability before calling portfolio_add_button
              • add a new method in the caller class to check permissions
              • name the capabilities consistently, eg mod/forum:export-post, mod/forum:export-attachment
              • figure out a way to disable (or enable) plugin instances per role.
              Show
              mjollnir Penny Leach added a comment - after discussion with MD the plan is to: the calling code can check has_capability before calling portfolio_add_button add a new method in the caller class to check permissions name the capabilities consistently, eg mod/forum:export-post, mod/forum:export-attachment figure out a way to disable (or enable) plugin instances per role.
              Hide
              mjollnir Penny Leach added a comment -

              MD said:
              10:53 <moodler_> hmm plugins, we did something similar for grade import/expot
              (relating to fourth point above)

              Show
              mjollnir Penny Leach added a comment - MD said: 10:53 <moodler_> hmm plugins, we did something similar for grade import/expot (relating to fourth point above)
              Hide
              mjollnir Penny Leach added a comment -

              closing this issue as resolved.

              the outstanding thing about trying to figure out a way to enable or disable instances per role is trickier and not necessarily needed right now so i will open a separate bug for it.

              Show
              mjollnir Penny Leach added a comment - closing this issue as resolved. the outstanding thing about trying to figure out a way to enable or disable instances per role is trickier and not necessarily needed right now so i will open a separate bug for it.
              Hide
              marina Marina Glancy added a comment -

              $ git grep MDL-15768
              lib/portfoliolib.php: * @todo MDL-15768 - check capabilities here
              

              Please note that all issues that are closed as resolved or won't fix but still have remaining TODO or @todo in core are linked to MDL-47779 as "causing regressions"

              The link will be removed when all TODOs are removed (under another issue)

              Show
              marina Marina Glancy added a comment - $ git grep MDL-15768 lib/portfoliolib.php: * @todo MDL-15768 - check capabilities here Please note that all issues that are closed as resolved or won't fix but still have remaining TODO or @todo in core are linked to MDL-47779 as "causing regressions" The link will be removed when all TODOs are removed (under another issue)

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    24/Nov/10