Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35084

      Issue Links

        Activity

        Hide
        Petr Škoda added a comment -

        done except backup/restore

        Show
        Petr Škoda added a comment - done except backup/restore
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Reopening this because of some SQL cross-db annoyances (detected under PG)

        Show
        Eloy Lafuente (stronk7) added a comment - Reopening this because of some SQL cross-db annoyances (detected under PG)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Hi, while trying to upgrade to latest HEAD I'm getting this under PG:

        ERROR: column "a.course" must appear in the GROUP BY clause or be used in an aggregate function

        SELECT COUNT('x') FROM mdl_assignment_submissions s JOIN mdl_assignment a ON a.id = s.assignment JOIN mdl_modules m ON m.name = 'assignment' JOIN mdl_course_modules cm ON (cm.module = m.id AND cm.instance = a.id) ORDER BY a.course, s.assignment

        Also, under MSSQL I get some errors.

        Attaching patch that should fix the problem, by splitting the $sqlfrom into two components and not using it in the COUNT statement.

        Important note: Both forum and glossary exhibit the same problem.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Hi, while trying to upgrade to latest HEAD I'm getting this under PG: ERROR: column "a.course" must appear in the GROUP BY clause or be used in an aggregate function SELECT COUNT('x') FROM mdl_assignment_submissions s JOIN mdl_assignment a ON a.id = s.assignment JOIN mdl_modules m ON m.name = 'assignment' JOIN mdl_course_modules cm ON (cm.module = m.id AND cm.instance = a.id) ORDER BY a.course, s.assignment Also, under MSSQL I get some errors. Attaching patch that should fix the problem, by splitting the $sqlfrom into two components and not using it in the COUNT statement. Important note: Both forum and glossary exhibit the same problem. Ciao
        Hide
        Petr Škoda added a comment -

        thanks, fixed

        Show
        Petr Škoda added a comment - thanks, fixed
        Hide
        Matt Gibson added a comment -

        Just tried this as a student and didn't get the file picker when submitting a file to the upload a single file assignment type. Is this deliberate (students don't get to use the file picker) or have I misconfigured it?

        Show
        Matt Gibson added a comment - Just tried this as a student and didn't get the file picker when submitting a file to the upload a single file assignment type. Is this deliberate (students don't get to use the file picker) or have I misconfigured it?
        Hide
        Dongsheng Cai added a comment -

        online assignment module needs file storage conversion.

        Show
        Dongsheng Cai added a comment - online assignment module needs file storage conversion.
        Hide
        Martin Dougiamas added a comment -

        1. Aparup is going to change this upgrade to store files with itemid == submission->id instead of userid.

        This will break dev sites unfortunately so upgrade from 1.9 again. Again.

        2. Yes, online assignment needs a filemanager element.

        Show
        Martin Dougiamas added a comment - 1. Aparup is going to change this upgrade to store files with itemid == submission->id instead of userid. This will break dev sites unfortunately so upgrade from 1.9 again. Again. 2. Yes, online assignment needs a filemanager element.
        Hide
        Petr Škoda added a comment -

        yes, the submission id is better there

        Show
        Petr Škoda added a comment - yes, the submission id is better there
        Hide
        Martin Dougiamas added a comment -

        See linked bugs

        Show
        Martin Dougiamas added a comment - See linked bugs
        Hide
        Petr Škoda added a comment -

        Linked bugs closed, closing, thanks!

        Show
        Petr Škoda added a comment - Linked bugs closed, closing, thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: