Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Gliffy Diagrams

        Issue Links

          Activity

          Petr Skoda created issue -
          Hide
          Petr Skoda added a comment -

          done except backup/restore

          Show
          Petr Skoda added a comment - done except backup/restore
          Petr Skoda made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Reopening this because of some SQL cross-db annoyances (detected under PG)

          Show
          Eloy Lafuente (stronk7) added a comment - Reopening this because of some SQL cross-db annoyances (detected under PG)
          Eloy Lafuente (stronk7) made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Hi, while trying to upgrade to latest HEAD I'm getting this under PG:

          ERROR: column "a.course" must appear in the GROUP BY clause or be used in an aggregate function

          SELECT COUNT('x') FROM mdl_assignment_submissions s JOIN mdl_assignment a ON a.id = s.assignment JOIN mdl_modules m ON m.name = 'assignment' JOIN mdl_course_modules cm ON (cm.module = m.id AND cm.instance = a.id) ORDER BY a.course, s.assignment

          Also, under MSSQL I get some errors.

          Attaching patch that should fix the problem, by splitting the $sqlfrom into two components and not using it in the COUNT statement.

          Important note: Both forum and glossary exhibit the same problem.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Hi, while trying to upgrade to latest HEAD I'm getting this under PG: ERROR: column "a.course" must appear in the GROUP BY clause or be used in an aggregate function SELECT COUNT('x') FROM mdl_assignment_submissions s JOIN mdl_assignment a ON a.id = s.assignment JOIN mdl_modules m ON m.name = 'assignment' JOIN mdl_course_modules cm ON (cm.module = m.id AND cm.instance = a.id) ORDER BY a.course, s.assignment Also, under MSSQL I get some errors. Attaching patch that should fix the problem, by splitting the $sqlfrom into two components and not using it in the COUNT statement. Important note: Both forum and glossary exhibit the same problem. Ciao
          Eloy Lafuente (stronk7) made changes -
          Attachment assignment_upgrade.patch.txt [ 14875 ]
          Hide
          Petr Skoda added a comment -

          thanks, fixed

          Show
          Petr Skoda added a comment - thanks, fixed
          Petr Skoda made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Matt Gibson added a comment -

          Just tried this as a student and didn't get the file picker when submitting a file to the upload a single file assignment type. Is this deliberate (students don't get to use the file picker) or have I misconfigured it?

          Show
          Matt Gibson added a comment - Just tried this as a student and didn't get the file picker when submitting a file to the upload a single file assignment type. Is this deliberate (students don't get to use the file picker) or have I misconfigured it?
          Dongsheng Cai made changes -
          Link This issue blocks MDL-22485 [ MDL-22485 ]
          Hide
          Dongsheng Cai added a comment -

          online assignment module needs file storage conversion.

          Show
          Dongsheng Cai added a comment - online assignment module needs file storage conversion.
          Dongsheng Cai made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Martin Dougiamas added a comment -

          1. Aparup is going to change this upgrade to store files with itemid == submission->id instead of userid.

          This will break dev sites unfortunately so upgrade from 1.9 again. Again.

          2. Yes, online assignment needs a filemanager element.

          Show
          Martin Dougiamas added a comment - 1. Aparup is going to change this upgrade to store files with itemid == submission->id instead of userid. This will break dev sites unfortunately so upgrade from 1.9 again. Again. 2. Yes, online assignment needs a filemanager element.
          Martin Dougiamas made changes -
          Link This issue will be resolved by MDL-22609 [ MDL-22609 ]
          Hide
          Petr Skoda added a comment -

          yes, the submission id is better there

          Show
          Petr Skoda added a comment - yes, the submission id is better there
          Martin Dougiamas made changes -
          Link This issue will be resolved by MDL-22893 [ MDL-22893 ]
          Hide
          Martin Dougiamas added a comment -

          See linked bugs

          Show
          Martin Dougiamas added a comment - See linked bugs
          Hide
          Petr Skoda added a comment -

          Linked bugs closed, closing, thanks!

          Show
          Petr Skoda added a comment - Linked bugs closed, closing, thanks!
          Petr Skoda made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Martin Dougiamas made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Martin Dougiamas made changes -
          Workflow jira [ 27748 ] MDL Workflow [ 60470 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 60470 ] MDL Full Workflow [ 89644 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: