Moodle
  1. Moodle
  2. MDL-15911

moodle ods library should have the same filehandling conventions as the excel one.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Files API, Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      639

      Description

      excel library sends the file to the browser if you pass '-' as the filename argument, else writes it to disk.

      ods library just sends it to the browser.

        Activity

        Hide
        Penny Leach added a comment -

        adding eloy

        Show
        Penny Leach added a comment - adding eloy
        Hide
        Penny Leach added a comment -

        in HEAD

        Show
        Penny Leach added a comment - in HEAD
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Uhm, Penny.

        Just to keep 100% the ods behaviour aligned with the excel one... could we use the same "-" trick in both? Or, alternatively, use both params in excellib too (filename and send).

        Adding Petr here, as he made ods export... ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Uhm, Penny. Just to keep 100% the ods behaviour aligned with the excel one... could we use the same "-" trick in both? Or, alternatively, use both params in excellib too (filename and send). Adding Petr here, as he made ods export... ciao
        Hide
        Penny Leach added a comment -

        I had a look at using the - trick in the ods lib, but it gets overridden anyway in the send() function a better option might be to change excellib to be the same but that breaks backwards compatibility....

        Show
        Penny Leach added a comment - I had a look at using the - trick in the ods lib, but it gets overridden anyway in the send() function a better option might be to change excellib to be the same but that breaks backwards compatibility....
        Hide
        Petr Škoda added a comment -

        oh, never heard of this excel option

        I think we will not need this much - most of the "export" stuff should be moved to pluginfile.php which will always send it to the browser. We might also create some new option to store it in local file storage.

        Show
        Petr Škoda added a comment - oh, never heard of this excel option I think we will not need this much - most of the "export" stuff should be moved to pluginfile.php which will always send it to the browser. We might also create some new option to store it in local file storage.
        Hide
        Penny Leach added a comment -

        reopening this - it should be resolved using the files api.

        Show
        Penny Leach added a comment - reopening this - it should be resolved using the files api.
        Hide
        Penny Leach added a comment -

        resassigning to petr.

        Show
        Penny Leach added a comment - resassigning to petr.
        Hide
        Penny Leach added a comment -

        If this ever makes it high up enough the list to be finished - prepare_package method in data_portfolio_caller needs updating to use new libraries.

        at the moment you can't export an entire data mod in anything other than csv - this should be fixed in the above method, and: mod/data/export.php which forces it to csv no matter what's in the form. also the (csv only) part of the string should be removed (portfolionotfile in data langfile)

        Show
        Penny Leach added a comment - If this ever makes it high up enough the list to be finished - prepare_package method in data_portfolio_caller needs updating to use new libraries. at the moment you can't export an entire data mod in anything other than csv - this should be fixed in the above method, and: mod/data/export.php which forces it to csv no matter what's in the form. also the (csv only) part of the string should be removed (portfolionotfile in data langfile)
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: