Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-15974

Unnecessary PHP Notices in lib/weblib.php and type/multichoice/questiontype.php

    XMLWordPrintable

Details

    • MOODLE_18_STABLE, MOODLE_19_STABLE
    • MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

    Description

      Noticing lots of noise in the webserver logs, such as:

      [error] PHP Notice: Undefined property: picture in /var/www/stjohn-moodle-18/moodle/lib/weblib.php on line 3512
      [error] PHP Notice: Undefined property: shuffleanswers in /var/www/stjohn-moodle-18/moodle/question/type/multichoice/questiontype.php on line 167
      [error] PHP Notice: Undefined property: delay1 in /var/www/stjohn-moodle-18/moodle/mod/quiz/attempt.php on line 173

      These are due to if ($variable) statements needing to be if (!empty($variable))

      Patch for MOODLE_18_STABLE (as of 2008-08-08) attached.

      Attachments

        Activity

          People

            timhunt Tim Hunt
            jonathan Jonathan Harker
            Andrew Davis Andrew Davis
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Safat Shahin, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              28/Jan/09