[MDL-15974] Unnecessary PHP Notices in lib/weblib.php and type/multichoice/questiontype.php - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.8.6, 1.9.2
Fix Version/s: 1.7.7, 1.8.8, 1.9.4
Component/s: General, Libraries, Questions, Quiz
Labels:
None

Affected Branches:
MOODLE_18_STABLE, MOODLE_19_STABLE
Fixed Branches:
MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

Description

Noticing lots of noise in the webserver logs, such as:

[error] PHP Notice: Undefined property: picture in /var/www/stjohn-moodle-18/moodle/lib/weblib.php on line 3512
[error] PHP Notice: Undefined property: shuffleanswers in /var/www/stjohn-moodle-18/moodle/question/type/multichoice/questiontype.php on line 167
[error] PHP Notice: Undefined property: delay1 in /var/www/stjohn-moodle-18/moodle/mod/quiz/attempt.php on line 173

These are due to if ($variable) statements needing to be if (!empty($variable))

Patch for MOODLE_18_STABLE (as of 2008-08-08) attached.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

empty-checks.diff
3 kB
08/Aug/08 5:13 PM
empty-checks-19.diff
3 kB
08/Aug/08 5:39 PM
empty-checks-cvshead.diff
1 kB
08/Aug/08 8:04 PM

Activity

People

Assignee:: Tim Hunt

Reporter:: Jonathan Harker

Tester:: Andrew Davis

Participants:: Andrew Davis, Jonathan Harker, Tim Hunt

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 08/Aug/08 5:13 PM

Updated:: 14/Dec/09 9:44 PM

Resolved:: 27/Nov/08 11:15 PM

Fix Release Date:: 28/Jan/09