Moodle
  1. Moodle
  2. MDL-16113

Add warning to scorm modedit page when Slasharg disabled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.9
    • Fix Version/s: 1.8.7, 1.9.3, 2.0
    • Component/s: SCORM
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      24346

      Description

      Scorm will not work correctly when Slasharguments are disabled.

      We need to add a check and throw a warning on the modedit page to warn users that their objects will not work with slasharguments disabled.

      • should add details about this to a FAQ in the documentation somewhere as well.

        Activity

        Hide
        Dan Marsden added a comment -

        adding patch that displays warning on modedit page if slashargs is enabled.

        Show
        Dan Marsden added a comment - adding patch that displays warning on modedit page if slashargs is enabled.
        Hide
        Dan Marsden added a comment -

        patch now in HEAD, 19stable and 18stable

        Dan

        Show
        Dan Marsden added a comment - patch now in HEAD, 19stable and 18stable Dan
        Hide
        Helen Foster added a comment -

        Hi Dan,

        Thanks for adding a warning when slash arguments are disabled.

        I tested with the latest 1.9.2 and found it to be working fine i.e. when slash arguments are disabled, the message "WARNING: slash arguments is disabled on this site and objects may not function as expected!" appears on the edit SCORM page.

        I was a bit confused though, because, despite the warning, the object (an eXe package in the Moodle Features Demo course) worked fine! What does "... not function as expected" actually mean?

        Also, how about adding an additional warning about SCORM not working when slash arguments are disabled to the configslasharguments lang string and rewording the warning on the edit SCORM page to make it less scary for teachers, for example

        WARNING: This SCORM package may not work properly, as the "slash arguments" site admin setting is disabled. Please contact your site administrator.

        Show
        Helen Foster added a comment - Hi Dan, Thanks for adding a warning when slash arguments are disabled. I tested with the latest 1.9.2 and found it to be working fine i.e. when slash arguments are disabled, the message "WARNING: slash arguments is disabled on this site and objects may not function as expected!" appears on the edit SCORM page. I was a bit confused though, because, despite the warning, the object (an eXe package in the Moodle Features Demo course) worked fine! What does "... not function as expected" actually mean? Also, how about adding an additional warning about SCORM not working when slash arguments are disabled to the configslasharguments lang string and rewording the warning on the edit SCORM page to make it less scary for teachers, for example WARNING: This SCORM package may not work properly, as the "slash arguments" site admin setting is disabled. Please contact your site administrator.
        Hide
        Petr Škoda added a comment -

        hi Helen,
        the scorm code ignores the slashargument setting now and always uses file.php/xx/xx that is why it works for you. It would not work before, the new message is just an extra warning to let ppl know that working slasharguments are required (mostly required for MS IIS).

        Petr

        Show
        Petr Škoda added a comment - hi Helen, the scorm code ignores the slashargument setting now and always uses file.php/xx/xx that is why it works for you. It would not work before, the new message is just an extra warning to let ppl know that working slasharguments are required (mostly required for MS IIS). Petr
        Hide
        Dan Marsden added a comment -

        thanks Helen - how about:

        WARNING: the site admin setting "slash arguments" is disabled. SCORM/AICC objects require and force the use of slash arguments. If your server does not support this, objects will not work correctly. Please contact your site administrator if this object does not work.

        Show
        Dan Marsden added a comment - thanks Helen - how about: WARNING: the site admin setting "slash arguments" is disabled. SCORM/AICC objects require and force the use of slash arguments. If your server does not support this, objects will not work correctly. Please contact your site administrator if this object does not work.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: