Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Messages
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      24845

      Description

      The message settings editing form can be improved to:

      • put the output plugins into columns, with the name at the top only.
      • tidy up the layout (whole thing centered, left-hand text should be right-justified etc)
      • XHTML Strict compliant

        Activity

        Hide
        Luis Rodrigues added a comment -

        All items done.

        I'm not sure about the align for the destination configuration so maybe we can reopen this in the future.

        Show
        Luis Rodrigues added a comment - All items done. I'm not sure about the align for the destination configuration so maybe we can reopen this in the future.
        Hide
        Martin Dougiamas added a comment -

        As discussed in chat, we can tidy this up a lot by:

        1) Moving the popup config as the first heading in the "destinations" config section
        2) Adding a new section to the providers config for "Messages from other users".

        I also did some cleaning up of the tables a bit just now ... they still have some width issues.

        Show
        Martin Dougiamas added a comment - As discussed in chat, we can tidy this up a lot by: 1) Moving the popup config as the first heading in the "destinations" config section 2) Adding a new section to the providers config for "Messages from other users". I also did some cleaning up of the tables a bit just now ... they still have some width issues.
        Hide
        Martin Dougiamas added a comment -

        I got a bit carried away and did some rather more major cleaning up. Removed lots of tables, added fieldsets, moved settings in popup plugin etc. Still needs help buttons and perhaps some work on the order (popup should always be first in my opinion, see TODOs in message/edit code.

        Show
        Martin Dougiamas added a comment - I got a bit carried away and did some rather more major cleaning up. Removed lots of tables, added fieldsets, moved settings in popup plugin etc. Still needs help buttons and perhaps some work on the order (popup should always be first in my opinion, see TODOs in message/edit code.
        Hide
        Luis Rodrigues added a comment - - edited

        1) Do you think this is really important? because all the processors are in and array the code is going to strange to make sure popup if the first

        2) Adding a new section to the providers config for "Messages from other users". was already done but i hadn't commit the file.

        "Can we perhaps NOT show plugins here unless they have been configured in the section below", why? since all the output plugins try to use defaults if they aren't configured.eg Email get user's real email

        Show
        Luis Rodrigues added a comment - - edited 1) Do you think this is really important? because all the processors are in and array the code is going to strange to make sure popup if the first 2) Adding a new section to the providers config for "Messages from other users". was already done but i hadn't commit the file. "Can we perhaps NOT show plugins here unless they have been configured in the section below", why? since all the output plugins try to use defaults if they aren't configured.eg Email get user's real email
        Hide
        Martin Dougiamas added a comment -

        I did a bit more cleaning up in the code and form. (screenshot attached)

        Yeah I agree the order is probably not so important. I was thinking about when we have 10 or more plugins here. The interface will get quite scary for users. Perhaps we need an admin interface later to enable/disable plugins (same as all the other types of plugins).

        I don't see the "Messages from other users" yet ...

        I do see the help buttons, but the help files are all stored in the messages section which is wrong. Providers should specify the help file location, since it will probably be part of the module (eg forum will provide help for its own functions). Thinking about it, we probably need to specify the help file as part of the messageproviders array .. and use that when building the edit interface. Make sense?

        Show
        Martin Dougiamas added a comment - I did a bit more cleaning up in the code and form. (screenshot attached) Yeah I agree the order is probably not so important. I was thinking about when we have 10 or more plugins here. The interface will get quite scary for users. Perhaps we need an admin interface later to enable/disable plugins (same as all the other types of plugins). I don't see the "Messages from other users" yet ... I do see the help buttons, but the help files are all stored in the messages section which is wrong. Providers should specify the help file location, since it will probably be part of the module (eg forum will provide help for its own functions). Thinking about it, we probably need to specify the help file as part of the messageproviders array .. and use that when building the edit interface. Make sense?
        Hide
        Martin Dougiamas added a comment -

        I moved the help files a bit and changed how they are found ... make sure you update from cvs before any editing. The current implementation sort of works but perhaps the best way would be if provider definition had help location.

        Show
        Martin Dougiamas added a comment - I moved the help files a bit and changed how they are found ... make sure you update from cvs before any editing. The current implementation sort of works but perhaps the best way would be if provider definition had help location.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: