Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-1626

Forum: Per-discussion subscription

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9, 2.0.1, 2.6, 2.8
    • Fix Version/s: 2.8
    • Component/s: Forum
    • Labels:
    • Environment:
      All
    • Testing Instructions:
      Hide

      There are fairly extensive unit tests which accompany this issue, and behat tests which cover a selection of it.

      The tests currently do not cover:

      • moving discussions between forums; or
      • backup/restore.
      Moving discussions
      1. create a forum with a subscription mode of Auto and a name of "Auto forum"
      2. post a discussion in the forum with the subject "Automatic discussion"
        • Confirm that you are subscribed to the post
      3. create a forum with a subscription mode of Optional and a name of "Optional forum"
      4. post a discussion in the forum with the subject "Optional discussion"
        • Confirm that you are not subscribed to the post
      5. View the "Optional discussion" discussion
      6. Move the discussion to the Automatic forum
      7. View the Automatic forum threadlist
        • Confirm that you are:
        • *subscribed to the "Automatic discussion"
        • *unsubscribed to the "Optional discussion"
      8. View "Automatic discussion"
      9. Move the discussion to the Optional forum
      10. View the Optional forum threadlist
        • *Confirm that you are subscribed to "Automatic discussion"
      11. View "Automatic discussion" again
      12. Move the discussion back to the Automatic forum
      13. View the Automatic forum threadlist
        • Confirm that you are:
        • *subscribed to the "Automatic discussion"
        • *unsubscribed to the "Optional discussion"
      14. View the "Optional discussion" discussion
      15. Move the discussion back to the Optional forum
      16. View the Optional forum threadlist
        • *Confirm that you are unsubscribed from "Optional discussion"
      17. Subscribe yourself to the "Optional discussion" discussion
      18. View the Automatic forum threadlist
        • *Confirm that you are subscribed to "Automatic discussion"
      19. Unsubscribe yourself from the "Automatic discussion" discussion
      20. View the "Optional discussion" discussion (which you're now subscribed to)
      21. Move the discussion to the Automatic forum
      22. View the Automatic forum threadlist
        • Confirm that you are:
        • *unsubscribed from the "Automatic discussion"
        • *subscribed to the "Optional discussion"
      23. View "Automatic discussion" (which you're no longer subscribed to)
      24. Move the discussion to the Optional forum
      25. View the Optional forum threadlist
        • *Confirm that you are now unsubscribed from "Automatic discussion"
      26. View "Automatic discussion" again
      27. Move the discussion back to the Automatic forum
      28. View the Automatic forum threadlist
        • Confirm that you are:
        • *unsubscribed from the "Automatic discussion"
        • *subscribed to the "Optional discussion"
      Backup/restore
      1. Create a forum in optional subscription mode
      2. Create two discussions within it
      3. As student1:
        • Subscribe to discussion 1
      4. As student2:
        • Subscribe to discussion 2
      5. As student3:
        • Subscribe to the forum
      6. As student4:
        • Subscribe to the forum
        • Unsubscribe from discussion 1
      7. As student5:
        • Subscribe to the forum
        • Unsubscribe from discussion 2
      8. As admin, backup the forum including user data
      9. Restore the forum
      10. For each of the users above: Confirm that the subscription data was copied over correctly

      You should also move around the UI to check that it behaves as expected. Pay particular notice to:

      • the discussion list - you should be able to toggle the discussion subscription from the discussions and have them update from one to other
      • writing a new post - this displays information about your current subscription. It also defaults to subscribing you to the discussion when you post any message to that discussion
      Show
      There are fairly extensive unit tests which accompany this issue, and behat tests which cover a selection of it. The tests currently do not cover: moving discussions between forums; or backup/restore. Moving discussions create a forum with a subscription mode of Auto and a name of "Auto forum" post a discussion in the forum with the subject "Automatic discussion" Confirm that you are subscribed to the post create a forum with a subscription mode of Optional and a name of "Optional forum" post a discussion in the forum with the subject "Optional discussion" Confirm that you are not subscribed to the post View the "Optional discussion" discussion Move the discussion to the Automatic forum View the Automatic forum threadlist Confirm that you are: *subscribed to the "Automatic discussion" *unsubscribed to the "Optional discussion" View "Automatic discussion" Move the discussion to the Optional forum View the Optional forum threadlist *Confirm that you are subscribed to "Automatic discussion" View "Automatic discussion" again Move the discussion back to the Automatic forum View the Automatic forum threadlist Confirm that you are: *subscribed to the "Automatic discussion" *unsubscribed to the "Optional discussion" View the "Optional discussion" discussion Move the discussion back to the Optional forum View the Optional forum threadlist *Confirm that you are unsubscribed from "Optional discussion" Subscribe yourself to the "Optional discussion" discussion View the Automatic forum threadlist *Confirm that you are subscribed to "Automatic discussion" Unsubscribe yourself from the "Automatic discussion" discussion View the "Optional discussion" discussion (which you're now subscribed to) Move the discussion to the Automatic forum View the Automatic forum threadlist Confirm that you are: *unsubscribed from the "Automatic discussion" *subscribed to the "Optional discussion" View "Automatic discussion" (which you're no longer subscribed to) Move the discussion to the Optional forum View the Optional forum threadlist *Confirm that you are now unsubscribed from "Automatic discussion" View "Automatic discussion" again Move the discussion back to the Automatic forum View the Automatic forum threadlist Confirm that you are: *unsubscribed from the "Automatic discussion" *subscribed to the "Optional discussion" Backup/restore Create a forum in optional subscription mode Create two discussions within it As student1: Subscribe to discussion 1 As student2: Subscribe to discussion 2 As student3: Subscribe to the forum As student4: Subscribe to the forum Unsubscribe from discussion 1 As student5: Subscribe to the forum Unsubscribe from discussion 2 As admin, backup the forum including user data Restore the forum For each of the users above: Confirm that the subscription data was copied over correctly You should also move around the UI to check that it behaves as expected. Pay particular notice to: the discussion list - you should be able to toggle the discussion subscription from the discussions and have them update from one to other writing a new post - this displays information about your current subscription. It also defaults to subscribing you to the discussion when you post any message to that discussion
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_26_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-1626-master
    • Story Points (Obsolete):
      100
    • Sprint:
      FRONTEND Sprint 12

      Description

      I am finding that my inbox is absolutely flooded with unwanted moodle mails off the forum script. This is very annoying and I know it will similarly annoy my users. In fact it will put them off the system.

      The problem arises because unlike other discussion boards moodle messages are emailed to me from the entire forum, not just the thread I have started or responded to. The overwhelming of people's inboxes is a serious business: it could be said that moodle is generating spam because the email feature is so unfocused.

      Is there any chance this is going to be improved please?

        Gliffy Diagrams

          Attachments

          1. unsubscribed-forum-newpost.png
            unsubscribed-forum-newpost.png
            58 kB
          2. ThreadSubscriptions.pdf
            338 kB
          3. threadsubscribingforum_2.5.0.patch
            101 kB
          4. threadlist.png
            threadlist.png
            26 kB
          5. thread_subscribe1.png
            thread_subscribe1.png
            122 kB
          6. thread_subscribe1.bmml
            12 kB
          7. thread_subscribe1.bmml
            12 kB
          8. subscribed-forum-newpost.png
            subscribed-forum-newpost.png
            58 kB
          9. Per-forum subscription.png
            Per-forum subscription.png
            87 kB
          10. Per-forum subscription.pdf
            48 kB
          11. moodle 1.9.4 (chk)-diff-2009-02-23-00-00-16.patch
            111 kB
          12. moodle 1.9.4 (chk)-diff-2009-02-21-16-14-30.patch
            111 kB
          13. moodle 1.9.3 (chk)-diff-2009-01-31-20-20-44.patch
            55 kB
          14. discussion-view.png
            discussion-view.png
            30 kB
          15. coverage.zip
            871 kB
          16. 1626.gitpatch
            18 kB

            Issue Links

              Activity

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14