Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-16431

Custom scales displaying instead of site-wide scales when creating "Grade Items" in 1.9

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.2
    • Fix Version/s: 1.9.5
    • Component/s: Gradebook
    • Labels:
      None
    • Environment:
      Moodle 1.9.2
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      By default, individual course scales should not be accessible to other users on the site unless they've been designated a site-wide "standard" scale, which is something only admins can do.

      However, we've discovered that if you create a Grade Item (via Grades > Choose an Action > Categories & Items > Add Grade Item) and click on the "Scale" drop down menu, you see all the custom scales available on the site.

      The steps to recreate are:

      1) Create a custom scale for Course A as Teacher A
      2) Assign that scale to a grade item in Course A.
      3) Create a grade item in Course B as Teacher B
      4) Add a grade item, and look at the scale menu; if the bug is there, then you'll be able to see the custom scale that should have been limited to to just Course A.

      In looking through the code, I discovered the problem lies on line 60:

      if ($scales = get_records('scale')) {

      This query returns every scale in Moodle, both custom and site-wide, rather than just those for the course.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/09