Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Gliffy Diagrams

        Attachments

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -
            • file and picture element migrated
            • waiting for file picker to mature - more pickers on one form, etc. - we will steal the integration code from filepicker forms element
            • presets not finished yet
            Show
            skodak Petr Skoda added a comment - file and picture element migrated waiting for file picker to mature - more pickers on one form, etc. - we will steal the integration code from filepicker forms element presets not finished yet
            Hide
            skodak Petr Skoda added a comment -

            after spending several hours on preset files I have decided to add a new table instead - it should be far more flexible and much easier to implement :-D

            Show
            skodak Petr Skoda added a comment - after spending several hours on preset files I have decided to add a new table instead - it should be far more flexible and much easier to implement :-D
            Hide
            mjollnir Penny Leach added a comment -

            Why did you make data_field_picture subclass data_field_base directly rather than data_field_file?

            That causes some yuk special cases for me which is fine if there's a good reason - just wondering what it is..

            http://cvs.moodle.org/moodle/mod/data/field/picture/field.class.php?r1=1.28&r2=1.29

            Show
            mjollnir Penny Leach added a comment - Why did you make data_field_picture subclass data_field_base directly rather than data_field_file? That causes some yuk special cases for me which is fine if there's a good reason - just wondering what it is.. http://cvs.moodle.org/moodle/mod/data/field/picture/field.class.php?r1=1.28&r2=1.29
            Hide
            skodak Petr Skoda added a comment -

            I did that because it does not share any method anymore, all methods from file are overriden.
            We can change it back, but what would be the benefit?

            Show
            skodak Petr Skoda added a comment - I did that because it does not share any method anymore, all methods from file are overriden. We can change it back, but what would be the benefit?
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Petr,
            Could you please have a look at this for me?
            It is a patch for handle the uploading/downloading of database presets through the new file API.
            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Petr, Could you please have a look at this for me? It is a patch for handle the uploading/downloading of database presets through the new file API. Cheers Sam
            Hide
            dougiamas Martin Dougiamas added a comment -

            SOme more things to be done:

            1) File field should just use one filepicker element
            2) Picture field should just use one filepicker element
            3) URL field should just use one url element

            Show
            dougiamas Martin Dougiamas added a comment - SOme more things to be done: 1) File field should just use one filepicker element 2) Picture field should just use one filepicker element 3) URL field should just use one url element
            Hide
            skodak Petr Skoda added a comment -

            ah, sorry I overlooked this, unfortunately it is nut suitable any more due to the recent changes in file api, sorry

            Show
            skodak Petr Skoda added a comment - ah, sorry I overlooked this, unfortunately it is nut suitable any more due to the recent changes in file api, sorry
            Hide
            samhemelryk Sam Hemelryk added a comment -

            This has been resolved now by recent changes to the database modules file handling.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - This has been resolved now by recent changes to the database modules file handling. Cheers Sam

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  24/Nov/10