Moodle
  1. Moodle
  2. MDL-16522

Strange 'Logs' tab appears on Theme tab of MNET host configuration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.2
    • Fix Version/s: 1.9.7
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      31121

      Description

      When looking at an MNET peer under Networking -> Peers, there are three tabs: Review Host Details, Services and Themes.

      Strangely, clicking on the Themes tab reveals a fourth tab - Logs.

      Clicking this takes you to some other area of Moodle that looks like some kind of log viewer. It's got no data in it for me, but that might be because it's a new install.

      Pretty sure that tab shouldn't be there

        Activity

        Hide
        Dan Marsden added a comment -

        the code used for displaying tabs in mnet was a mess - duplication of inconsistant code - that logs tab should only display for Moodle Peers - not Mahara peers (haven't checked if it actually works with Moodle peers, but that's another issue)

        the code now uses a tabs.php file - but the structure of those pages could do with a further tidy!

        Show
        Dan Marsden added a comment - the code used for displaying tabs in mnet was a mess - duplication of inconsistant code - that logs tab should only display for Moodle Peers - not Mahara peers (haven't checked if it actually works with Moodle peers, but that's another issue) the code now uses a tabs.php file - but the structure of those pages could do with a further tidy!
        Hide
        Andrew Davis added a comment -

        Fix looks good. Always good to see duplicate code getting ripped out Closing.

        Show
        Andrew Davis added a comment - Fix looks good. Always good to see duplicate code getting ripped out Closing.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: