Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-16560

Keyswap failure due to erroneous call to undefined function param_clean()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8, 1.8.1, 1.8.2, 1.8.3, 1.8.4, 1.8.5, 1.8.6, 1.9, 1.9.1, 1.9.2
    • Fix Version/s: 1.8.7, 1.9.3, 2.0
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      As discussed with PeterB.

      Background reading: I was tracing keyswap today for problems, and found that we were 99% done, except for the very very last bit where Moodle attempted to refresh the key. It was calling the undefined param_clean function and dying, instead of returning that the key refreshing was successful and letting the request continue.

      The attached patch fixes this problem, and combined with a patch I'm submitting to Mahara, means that if you're SSOing from Moodle to Mahara and Mahara's key has changed, it'll all keep working.

      This will probably fix the same case with Moodle to Moodle SSO.

        Gliffy Diagrams

          Activity

          Hide
          peterbulmer Peter Bulmer added a comment -

          Thanks Nigel, this issue has been patched.

          Show
          peterbulmer Peter Bulmer added a comment - Thanks Nigel, this issue has been patched.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Oct/08