Moodle
  1. Moodle
  2. MDL-16583 Clean up JavaScript usage in HEAD
  3. MDL-16654

Emoticons help file contains JavaScript to insert the emoticons, but it won't acutally work in a lot of situations

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35504

      Description

      It relies on storing the id of the most recently output textarea in the session, which is then used to generate some JavaScript on the fly when that help page is shown. This will fail on pages with more that one HTML editor, or where the users is browsing in multiple tabs. I think we should just eliminate this feature, especially because the JavaScript is added to every single page that Moodle loads.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          This misfeature dates from at least Moodle 1.3 times:

          http://cvs.moodle.org/moodle/lang/en/help/emoticons.html?hideattic=0&revision=1.1&view=markup

          At the very least, the JavaScript should be moved so it is only added to that help page.

          Show
          Tim Hunt added a comment - This misfeature dates from at least Moodle 1.3 times: http://cvs.moodle.org/moodle/lang/en/help/emoticons.html?hideattic=0&revision=1.1&view=markup At the very least, the JavaScript should be moved so it is only added to that help page.
          Hide
          Tim Hunt added a comment -

          Actually, I have now worked out how to clean up the code, so I'll do that.

          Show
          Tim Hunt added a comment - Actually, I have now worked out how to clean up the code, so I'll do that.

            People

            • Assignee:
              Tim Hunt
              Reporter:
              Tim Hunt
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: