Details

    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The new "editor" form element is similar to the old "htmleditor" component in that it will print an editor for text etc (like tinymce).

      In addtion it:

      • requires draftfileareaid, format, current language (and possibly more things later) passed in using JS globals
      • will use the repository filepicker at all input points within the editor interface

      Later on we can add:

      • support for special editors for special formats.
      • support conversion of formats (eg into html).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dongsheng Dongsheng Cai added a comment -

              Filepicker works now.

              Show
              dongsheng Dongsheng Cai added a comment - Filepicker works now.
              Hide
              dongsheng Dongsheng Cai added a comment -

              Finally figured out how to convert draft files, here is a patch to convert htmleditor to editor in mod/forum, it worked, I will double check tomorrow.

              Show
              dongsheng Dongsheng Cai added a comment - Finally figured out how to convert draft files, here is a patch to convert htmleditor to editor in mod/forum, it worked, I will double check tomorrow.
              Hide
              skodak Petr Skoda added a comment -

              nice, looks ok, I fixed some warnings when adding new posts and added $draftid_editor = file_get_submitted_draftitemid('message'); when solves form reloading problems

              please commit into HEAD

              Show
              skodak Petr Skoda added a comment - nice, looks ok, I fixed some warnings when adding new posts and added $draftid_editor = file_get_submitted_draftitemid('message'); when solves form reloading problems please commit into HEAD
              Hide
              timhunt Tim Hunt added a comment -

              Before it is too late, can I suggest a name change?

              I think form elements should be named according to what you are editing, not how you edit it. So I think this element should be called 'htmlcontent' or something like that. That approach makes the form definition more declarative, and makes it easier to make usability improvements in future.

              Show
              timhunt Tim Hunt added a comment - Before it is too late, can I suggest a name change? I think form elements should be named according to what you are editing, not how you edit it. So I think this element should be called 'htmlcontent' or something like that. That approach makes the form definition more declarative, and makes it easier to make usability improvements in future.
              Hide
              dougiamas Martin Dougiamas added a comment -

              If we do this then I think the best name would be text but we have one of those for something else.

              The main distinguishing feature is that this element supports all editors (not just html editors either, it depends on the format of the text).

              Show
              dougiamas Martin Dougiamas added a comment - If we do this then I think the best name would be text but we have one of those for something else. The main distinguishing feature is that this element supports all editors (not just html editors either, it depends on the format of the text).
              Hide
              skodak Petr Skoda added a comment -

              kind of works, closing

              Show
              skodak Petr Skoda added a comment - kind of works, closing

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    24/Nov/10