Moodle
  1. Moodle
  2. MDL-16781

Lower case in setting menu of quiz

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.6, 1.7.5, 1.8.6, 1.9.2
    • Fix Version/s: 1.6.9, 1.7.7, 1.8.8, 1.9.4
    • Component/s: Quiz
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      26342

      Description

      In the settings menu the translated text for the 'attempts' is automatically switched to lower cases, also if they are correct in the language file.

      example: German attempts: Versuche is visible as 'versuche' in the menu.

      1. attempts.png
        15 kB
      2. versuch.png
        194 kB

        Activity

        Hide
        Tim Hunt added a comment -

        Which menu? A screenshot or a URL would help.

        Show
        Tim Hunt added a comment - Which menu? A screenshot or a URL would help.
        Hide
        Ralf Hilgenstock added a comment -

        Hi Tim,

        sorry for late response. I add a screenshot.

        Show
        Ralf Hilgenstock added a comment - Hi Tim, sorry for late response. I add a screenshot.
        Hide
        Tim Hunt added a comment -

        OK. Now why is that a problem?

        Actually, it is probalby more of a problem that we are concatenating the string, rather than using the 3rd argument of get_string.

        Actually, why don't we just say:

        Attempts allowed: Unlimited/1/2/3/4/...

        Repeating the word attempts is rather redundant. Wow! that code has been there right from the start! http://cvs.moodle.org/moodle/mod/quiz/mod.html?hideattic=0&revision=1.1&view=markup

        Anyway, what do you suggest?

        Show
        Tim Hunt added a comment - OK. Now why is that a problem? Actually, it is probalby more of a problem that we are concatenating the string, rather than using the 3rd argument of get_string. Actually, why don't we just say: Attempts allowed: Unlimited/1/2/3/4/... Repeating the word attempts is rather redundant. Wow! that code has been there right from the start! http://cvs.moodle.org/moodle/mod/quiz/mod.html?hideattic=0&revision=1.1&view=markup Anyway, what do you suggest?
        Hide
        Tim Hunt added a comment -

        Ping! Still waiting for a suggestion of what you want me to do to fix this.

        Show
        Tim Hunt added a comment - Ping! Still waiting for a suggestion of what you want me to do to fix this.
        Hide
        Ralf Hilgenstock added a comment -

        Hi Tim,

        sorry for late reply.

        Attempts allowed: Unlimited/1/2/3/4/...

        This suggestion may work in the German translation. I can edit the translation in this way.
        The term 'Unlimited' will appear as 'unlimited' with lower cases.

        I think it is more a general aspect. Translated strings should be shown in the same way they are translated and not changed in any way. I don't know what the consequences in other languages could be.

        Show
        Ralf Hilgenstock added a comment - Hi Tim, sorry for late reply. Attempts allowed: Unlimited/1/2/3/4/... This suggestion may work in the German translation. I can edit the translation in this way. The term 'Unlimited' will appear as 'unlimited' with lower cases. I think it is more a general aspect. Translated strings should be shown in the same way they are translated and not changed in any way. I don't know what the consequences in other languages could be.
        Hide
        Ralf Hilgenstock added a comment -

        Hi Tim,

        the string attempts is not only used for the pulldownmenu. See screenshot. And in the menu is a combination of a number and the 'attempts' string used. If I delete the entry in the string it is missing at other places. I think we need a new string.

        Where can I find the singular term of 'attempts'? Couldn't find it in quiz.php

        Show
        Ralf Hilgenstock added a comment - Hi Tim, the string attempts is not only used for the pulldownmenu. See screenshot. And in the menu is a combination of a number and the 'attempts' string used. If I delete the entry in the string it is missing at other places. I think we need a new string. Where can I find the singular term of 'attempts'? Couldn't find it in quiz.php
        Hide
        Tim Hunt added a comment -

        Done. Thanks for your help Ralph.

        Show
        Tim Hunt added a comment - Done. Thanks for your help Ralph.
        Hide
        Petr Škoda added a comment -

        thanks

        Show
        Petr Škoda added a comment - thanks

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: