Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3
    • Fix Version/s: None
    • Component/s: Administration, Usability
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      4707

      Description

      This small update adds a button to the user filters class, which helps in situations, when user has to change filters a lot of times to select users on some criteria. Pressing on this button deletes all active filters and adds a new one, specified in the form, thus removing one click in "type in filter - add filter - do something with results - delete filter - type in filter - add filter..." cycle.

      1. 2009-07-16 17:11.bmml
        7 kB
        Vlas Voloshin
      2. replace_filters_lang.patch
        0.6 kB
        Chris Bandy
      1. 2009-07-16 17:11.png
        80 kB

        Issue Links

          Activity

          Hide
          Chris Bandy added a comment -

          Vlas' patch looks perfect. To facilitate acceptance, here is the missing language string in English.

          Show
          Chris Bandy added a comment - Vlas' patch looks perfect. To facilitate acceptance, here is the missing language string in English.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          +1 for this. Assigning to Martin

          Show
          Eloy Lafuente (stronk7) added a comment - +1 for this. Assigning to Martin
          Hide
          Vlas Voloshin added a comment -

          Right, I forgot to add both English and Russian strings, thanks

          Show
          Vlas Voloshin added a comment - Right, I forgot to add both English and Russian strings, thanks
          Hide
          Anthony Borrow added a comment -

          Would it be better to have two buttons or to have the default behavior be to remove the filters and just search and then use the add filter pushbutton to do what it describes? I've not looked at the patch but from a usability perspective, one is a simple search and the other is creating a set of filter criteria. Of course we do call it a filter so users may expect it to behave like one from the get go. I'm open to thoughts as to what seems to make the most sense but certainly add my own +1 to improving this. Peace - Anthony

          Show
          Anthony Borrow added a comment - Would it be better to have two buttons or to have the default behavior be to remove the filters and just search and then use the add filter pushbutton to do what it describes? I've not looked at the patch but from a usability perspective, one is a simple search and the other is creating a set of filter criteria. Of course we do call it a filter so users may expect it to behave like one from the get go. I'm open to thoughts as to what seems to make the most sense but certainly add my own +1 to improving this. Peace - Anthony
          Hide
          Vlas Voloshin added a comment -

          Added UI Mockup: <2009-07-16 17:11>

          Show
          Vlas Voloshin added a comment - Added UI Mockup: <2009-07-16 17:11>
          Hide
          Vlas Voloshin added a comment -

          I'm not really sure whether I understood it right - but I may suggest a layout I made on the mockup.
          This way we may have a usual set of criteria, which are empty by default ("Search criteria"), and a list of current search criteria ("Current search"), the ones which are used in the users list. If we want to set some "filter", we set up the values in "Search criteria" and press "Search". "Current search" list is then filled with those we set, and the list of users is filled with "filtered" ones. "Search criteria" is cleared so we may create a new one from the scratch.
          If we want to edit the criteria we set at this moment, we may press "Edit search" button. It reloads the page with "Search criteria" filled-in with current values (the same as in "Current search"), and we may just edit them and press "Search" again so these edited values are used. There may also be a button to clean up the values in "Search criteria".
          So if this interface is ok, I may try to code it

          Show
          Vlas Voloshin added a comment - I'm not really sure whether I understood it right - but I may suggest a layout I made on the mockup. This way we may have a usual set of criteria, which are empty by default ("Search criteria"), and a list of current search criteria ("Current search"), the ones which are used in the users list. If we want to set some "filter", we set up the values in "Search criteria" and press "Search". "Current search" list is then filled with those we set, and the list of users is filled with "filtered" ones. "Search criteria" is cleared so we may create a new one from the scratch. If we want to edit the criteria we set at this moment, we may press "Edit search" button. It reloads the page with "Search criteria" filled-in with current values (the same as in "Current search"), and we may just edit them and press "Search" again so these edited values are used. There may also be a button to clean up the values in "Search criteria". So if this interface is ok, I may try to code it

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: