Moodle
  1. Moodle
  2. MDL-17094

Allow translators to disable automatic language update during Moodle upgrade

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3
    • Fix Version/s: 1.9.4, 2.0
    • Component/s: Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      36840

      Description

      Before Moodle upgrade, the current language pack is automatically updated from download.moodle.org. For translators working with CVS, this replaces their CVS checkouts by the "static" pack from moodle.org
      This is a proposal to introduce new $CFG settings that disables automatic language update and let translators (lang pack maintainers) to keep their moodledata/lang/* up-to-date manually (as they do as CVS maintainers).

      1. MDL-17094.patch.txt
        2 kB
        David Mudrak
      2. MDL-17094-2.patch.txt
        2 kB
        David Mudrak

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          The patch implements this. It simply hides the note and disables the update of the lang pack.

          Show
          David Mudrak added a comment - The patch implements this. It simply hides the note and disables the update of the lang pack.
          Hide
          David Mudrak added a comment -

          QA to skodak, waiting for +1 before commit

          Show
          David Mudrak added a comment - QA to skodak, waiting for +1 before commit
          Hide
          Petr Škoda added a comment -

          +1 without the MDL-17094 in comment, devs can use cvs history to find the reason for commits

          Show
          Petr Škoda added a comment - +1 without the MDL-17094 in comment, devs can use cvs history to find the reason for commits
          Hide
          David Mudrak added a comment -

          Fixed in MOODLE_19_STABLE admin/index.php and HEAD lib/adminlib.php.

          I have moved MOODLE_19_MERGED from 1.286.2.23 to 1.286.2.24 too. But as the change had to be applied on a different file (lib/adminlib.php instead of admin/index.php), I did not really merge anything into HEAD admin/index.php. Is this correct procedure?

          Show
          David Mudrak added a comment - Fixed in MOODLE_19_STABLE admin/index.php and HEAD lib/adminlib.php. I have moved MOODLE_19_MERGED from 1.286.2.23 to 1.286.2.24 too. But as the change had to be applied on a different file (lib/adminlib.php instead of admin/index.php), I did not really merge anything into HEAD admin/index.php. Is this correct procedure?
          Hide
          Petr Škoda added a comment -

          hmm, could you please disable the lang update UI too if this option added

          Show
          Petr Škoda added a comment - hmm, could you please disable the lang update UI too if this option added
          Hide
          David Mudrak added a comment -

          The second patch disables admin/langimport.php as well. Please approve how the warning reads and whether to introduce new string at all or keep the warning in English here.

          Show
          David Mudrak added a comment - The second patch disables admin/langimport.php as well. Please approve how the warning reads and whether to introduce new string at all or keep the warning in English here.
          Hide
          Petr Škoda added a comment -

          +1 for commit, thanks

          Show
          Petr Škoda added a comment - +1 for commit, thanks
          Hide
          David Mudrak added a comment -

          Fixed in CVS, thanks for the help.

          Show
          David Mudrak added a comment - Fixed in CVS, thanks for the help.
          Hide
          Petr Škoda added a comment -

          thanks

          Show
          Petr Škoda added a comment - thanks

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: