Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17284 Add Olli's new quiz editing UI to Moodle 2.0
  3. MDL-17298

We should not add JavaScript to the YAHOO namespace

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: JavaScript, Quiz
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Sorry, this one is quite big. I don't know why I did not notice it before.

      We really should not be adding our code to the YAHOO library namespace. I would change

      YAHOO.cats.container -> question_bank
      YAHOO.quiz.container -> quiz_editor

      or something like that.

      <div id="module" is not very descriptive. Wouldn't something like id="questionbankcontents" be better?

      Do you really want to initialise on load, would onDomReady work better?

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              24/Nov/10