Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17395

Obsolete transaltion for auth_emaildescription English language string

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.6, 1.9.3, 2.0
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to Admin > Plugins > Authentication > Manage Authentication
      2. Enable email based registation
      3. Go to Admin > Plugins > Authentication > Email based registration
      4. Verify the string displayed at the top of the page
      Show
      Go to Admin > Plugins > Authentication > Manage Authentication Enable email based registation Go to Admin > Plugins > Authentication > Email based registration Verify the string displayed at the top of the page
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      English language string 'auth_emaildescription' in auth.php still reports Email based authentication as the default athentication method. This no longer holds true since the email based auth is disabled bu default on any new Moodle setup.

        Gliffy Diagrams

          Activity

          Hide
          timhunt Tim Hunt added a comment -

          Adjusting bogus fix version.

          Show
          timhunt Tim Hunt added a comment - Adjusting bogus fix version.
          Hide
          poltawski Dan Poltawski added a comment -

          Hi Helen,

          This string still seems to be wrong, I wonder if you have any thoughts on what we should change it to? It currently says:

          Email confirmation is the default authentication method. When the user signs up, choosing their own new username and password, a confirmation email is sent to the user's email address.
          This email contains a secure link to a page where the user can confirm their account. Future logins just check the username and password against the stored values in the Moodle database.

          Show
          poltawski Dan Poltawski added a comment - Hi Helen, This string still seems to be wrong, I wonder if you have any thoughts on what we should change it to? It currently says: Email confirmation is the default authentication method. When the user signs up, choosing their own new username and password, a confirmation email is sent to the user's email address. This email contains a secure link to a page where the user can confirm their account. Future logins just check the username and password against the stored values in the Moodle database.
          Hide
          tsala Helen Foster added a comment -

          Hi Dan, thanks for asking for my opinion. My suggested wording is as follows (adding a note about the self registration setting which is often missed):

          Email-based self-registration enables a user to create their own account via a 'Create new account' button on the login page. The user then receives an email containing a secure link to a page where they can confirm their account. Future logins just check the username and password against the stored values in the Moodle database.

          Note: In addition to enabling the plugin, email-based self-registration must also be selected from the self registration drop-down menu on the 'Manage authentication' page.

          Show
          tsala Helen Foster added a comment - Hi Dan, thanks for asking for my opinion. My suggested wording is as follows (adding a note about the self registration setting which is often missed): Email-based self-registration enables a user to create their own account via a 'Create new account' button on the login page. The user then receives an email containing a secure link to a page where they can confirm their account. Future logins just check the username and password against the stored values in the Moodle database. Note: In addition to enabling the plugin, email-based self-registration must also be selected from the self registration drop-down menu on the 'Manage authentication' page.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Helen, submitting that change for integration.

          To integrator: Can be cherry-picked to 22,23

          Show
          poltawski Dan Poltawski added a comment - Thanks Helen, submitting that change for integration. To integrator: Can be cherry-picked to 22,23
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Dan, has been integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Dan, has been integrated now
          Hide
          abgreeve Adrian Greeve added a comment -

          Email-based self-registration introduction string has been changed.
          Test passed

          Show
          abgreeve Adrian Greeve added a comment - Email-based self-registration introduction string has been changed. Test passed
          Hide
          poltawski Dan Poltawski added a comment -

          Congratulations!

          You've made it into the weekly release!

          Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
          http://www.youtube.com/watch?v=_QhpHUmVCmY

          Show
          poltawski Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Sep/12