Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17422

Paging in listlib is badly screwed

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.9.3
    • 1.9.4
    • Libraries
    • None
    • MOODLE_19_STABLE
    • MOODLE_19_STABLE

    Description

      The code that tried to work out when an item was moved off the end of one page, and onto the next/previous was broken in several ways.

      1. It tried to deal with up/down moves, but there was at least one off-by-one error.
      2. And it gave notices on the last page, when the last page was not full of items.
      3. And it only worked on the first list, when there were several on a page.

      4. It did not consider right and left moves at all, but if you move the first item on page 2 right, it becomes a child of the last item on page 1, so you need to switch pages, and vice versa.

      Attachments

        Activity

          People

            timhunt Tim Hunt
            timhunt Tim Hunt
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              28/Jan/09