Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3, 2.0
    • Fix Version/s: 2.0
    • Component/s: Events API
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      Got a patch, just need to review, commit & document.

        Gliffy Diagrams

          Activity

          Hide
          Penny Leach added a comment -

          Petr - I think this one could go in stable, what do you think ?

          Attaching 2 patches.

          Show
          Penny Leach added a comment - Petr - I think this one could go in stable, what do you think ? Attaching 2 patches.
          Hide
          Penny Leach added a comment -

          two patches:

          1. install event definitions in lib/locallib
          2. run event queue in cron (hard to believe that isn't there!)

          Show
          Penny Leach added a comment - two patches: 1. install event definitions in lib/locallib 2. run event queue in cron (hard to believe that isn't there!)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Looks ok for me (strange event queue wasn't in cron)... uhm..

          Show
          Eloy Lafuente (stronk7) added a comment - Looks ok for me (strange event queue wasn't in cron)... uhm..
          Hide
          Penny Leach added a comment -

          ok to go in stable ?

          petr I guess you've changed this in HEAD anyway with your local plugin stuff but I'd like to put it in 1.9

          Show
          Penny Leach added a comment - ok to go in stable ? petr I guess you've changed this in HEAD anyway with your local plugin stuff but I'd like to put it in 1.9
          Hide
          Petr Skoda added a comment -

          looks ok to me for 1.9.x,
          the HEAD has already different plugin infrastructure, please just make sure the events are processed in cron for all plugins in local

          Show
          Petr Skoda added a comment - looks ok to me for 1.9.x, the HEAD has already different plugin infrastructure, please just make sure the events are processed in cron for all plugins in local
          Hide
          Penny Leach added a comment -

          okie, committed to 1.9. will test head in a bit.

          Show
          Penny Leach added a comment - okie, committed to 1.9. will test head in a bit.
          Hide
          Petr Skoda added a comment -

          implemented in 2.0, not planned for 1.9.x, please use patch if necessary
          thanks penny

          Show
          Petr Skoda added a comment - implemented in 2.0, not planned for 1.9.x, please use patch if necessary thanks penny

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: