Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3
    • Fix Version/s: 1.9.5
    • Component/s: Tags
    • Labels:
      None
    • Database:
      PostgreSQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      30212

      Description

      Nothing happens when I choose some flagged tags and try to reset the flags. Moodle shows:
      "tag-name" – Reset
      But the tag is still flagged :-/

        Activity

        Hide
        David Mudrak added a comment -

        The same observed at my site running the latest Moodle 1.9.4+. Assigning to myself - I am going to look at it tommorow.

        Show
        David Mudrak added a comment - The same observed at my site running the latest Moodle 1.9.4+. Assigning to myself - I am going to look at it tommorow.
        Hide
        David Mudrak added a comment -

        This seems to be PostgreSQL specific bug. Postgres does not seem to support table alias in UPDATE statement. Therefore the SQL like

        UPDATE mdl_tag tg SET tg.flag = 0, tg.timemodified = 1236027984 WHERE tg.id IN (4)

        ends with an error
        ERROR: column "tg" of relation "mdl_tag" does not exist LINE 1: UPDATE mdl_tag tg SET tg.flag = 0, tg.timemodified = 1236027...

        The fix is quite easy - just do not use table alias as it makes no sense here anyway

        Show
        David Mudrak added a comment - This seems to be PostgreSQL specific bug. Postgres does not seem to support table alias in UPDATE statement. Therefore the SQL like UPDATE mdl_tag tg SET tg.flag = 0, tg.timemodified = 1236027984 WHERE tg.id IN (4) ends with an error ERROR: column "tg" of relation "mdl_tag" does not exist LINE 1: UPDATE mdl_tag tg SET tg.flag = 0, tg.timemodified = 1236027... The fix is quite easy - just do not use table alias as it makes no sense here anyway
        Hide
        David Mudrak added a comment -

        Fixed in MOODLE_19_STABLE and merged into HEAD.

        Show
        David Mudrak added a comment - Fixed in MOODLE_19_STABLE and merged into HEAD.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Verified. Closing. Thanks David! B-)

        Show
        Eloy Lafuente (stronk7) added a comment - Verified. Closing. Thanks David! B-)
        Hide
        Dennis Meyer added a comment -

        Thanks a lot!

        Show
        Dennis Meyer added a comment - Thanks a lot!

          People

          • Votes:
            3 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: