Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17548

MNET jump links in forum emails have incorrect path when wwwroot contains a path

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.3, 2.0
    • Fix Version/s: 1.9.4
    • Component/s: Forum, Messages, MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      If $CFG->wwwroot contains a path component (e.g. /moodle in http://contentprovider.com/moodle or similar), then the MNET jump URLs to the forum threads on the CP that get written into forum emails contain a double-up of the path - on the end of hostwwwroot and the beginning of wantsurl. For instance:

      http://idprovider.com/mnet/jump.php?hostwwwroot=http://contentprovider.com/moodle&wantsurl=/moodle/mod/forum/discuss.php...

      Attached fix.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            jonathan Jonathan Harker added a comment -

            Patch for head - PHP 5 supports the extra PHP_URL_PATH parameter.

            Show
            jonathan Jonathan Harker added a comment - Patch for head - PHP 5 supports the extra PHP_URL_PATH parameter.
            Hide
            jonathan Jonathan Harker added a comment -

            Fix for MOODLE_19_STABLE has to support the PHP 4 incantation of parse_url

            Show
            jonathan Jonathan Harker added a comment - Fix for MOODLE_19_STABLE has to support the PHP 4 incantation of parse_url
            Hide
            poltawski Dan Poltawski added a comment -

            (Not really looked at this - ). But presumably this fixes the wantsurl part?

            Show
            poltawski Dan Poltawski added a comment - (Not really looked at this - ). But presumably this fixes the wantsurl part?
            Hide
            peterbulmer Peter Bulmer added a comment -

            DanP, Yep.

            I've looked at it, it's a good patch IMO

            Show
            peterbulmer Peter Bulmer added a comment - DanP, Yep. I've looked at it, it's a good patch IMO
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            +1 yay!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - +1 yay!
            Hide
            jonathan Jonathan Harker added a comment -

            Now committed to HEAD and MOODLE_19_STABLE
            Cheers again
            J

            Show
            jonathan Jonathan Harker added a comment - Now committed to HEAD and MOODLE_19_STABLE Cheers again J
            Hide
            poltawski Dan Poltawski added a comment -

            Closing as fixed as this has been commited

            Show
            poltawski Dan Poltawski added a comment - Closing as fixed as this has been commited

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Jan/09