Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-17761

get_string: improved error checking with use of eval

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3
    • Fix Version/s: 1.9.4
    • Component/s: Libraries
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      From http://cvs.moodle.org/moodle/lib/moodlelib.php?r1=1.960.2.49&r2=1.960.2.50&pathrev=MOODLE_19_STABLE it appears that we were checking that eval functioned properly before continuing but we did not check the two parent language uses of eval. The attached patch adds the same check introduced above to the parent language section of the get_string function. Peace - Anthony

        Attachments

          Activity

            People

            Assignee:
            aborrow Anthony Borrow
            Reporter:
            aborrow Anthony Borrow
            Tester:
            Petr Skoda
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/Jan/09