Moodle
  1. Moodle
  2. MDL-17777

Improve $FULLME, $ME and add $SCRIPT and $FULLSCRIPT

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE

      Description

      The major problems here are:

      • reverse proxies
      • SSL accelerators

      $FULLME - should always contain full url starting with wwwroot (and https: if https enabled) including page parameters and slasharguments
      $ME - like FULLME but without the query part
      $SCRIPT - relative me, like ME without wwwroot - ex: "/course/view.php", "/admin/cron.php"

      the cron should stop using FULLME == 'cron' and instead use $SCRIPT == "/$CFG->admin/cron.php"

      -------
      This is just the first step towards reversed proxy and SSL accel support
      This will also help with detection of incorrect access addresses.

        Gliffy Diagrams

          Issue Links

            Activity

            Petr Skoda created issue -
            Petr Skoda made changes -
            Field Original Value New Value
            Description The major problems here are:
            * reverse proxies
            * SSL accelerators

            FULLME - should always contain full url starting with wwwroot (and https: if https enabled) including page parameters
            ME - like FULLME but without the query part
            RELME - relative me, like ME without wwwroot - ex: "/course/view.php", "/admin/cron.php"

            the $FULLME, $ME and $RELME should match them

            the cron should stop using FULLME == 'cron' and instead use "/$CFG->admin/cron.php"


            -------
            This is just the first step towards reversed proxy and SSL accel support ;-)
            The major problems here are:
            * reverse proxies
            * SSL accelerators

            FULLME - should always contain full url starting with wwwroot (and https: if https enabled) including page parameters
            ME - like FULLME but without the query part
            RELME - relative me, like ME without wwwroot - ex: "/course/view.php", "/admin/cron.php"

            the $FULLME, $ME and $RELME should match them

            the cron should stop using FULLME == 'cron' and instead use "/$CFG->admin/cron.php"


            -------
            This is just the first step towards reversed proxy and SSL accel support ;-)
            This will also help with detection of incorrect access addresses.
            Petr Skoda made changes -
            Link This issue has been marked as being related by MDL-17754 [ MDL-17754 ]
            Petr Skoda made changes -
            Summary Improve FULLME, ME and add RELME Improve $FULLME, $ME and add $SCRIPT and $FULLSCRIPT
            Description The major problems here are:
            * reverse proxies
            * SSL accelerators

            FULLME - should always contain full url starting with wwwroot (and https: if https enabled) including page parameters
            ME - like FULLME but without the query part
            RELME - relative me, like ME without wwwroot - ex: "/course/view.php", "/admin/cron.php"

            the $FULLME, $ME and $RELME should match them

            the cron should stop using FULLME == 'cron' and instead use "/$CFG->admin/cron.php"


            -------
            This is just the first step towards reversed proxy and SSL accel support ;-)
            This will also help with detection of incorrect access addresses.
            The major problems here are:
            * reverse proxies
            * SSL accelerators

            $FULLME - should always contain full url starting with wwwroot (and https: if https enabled) including page parameters and slasharguments
            $ME - like FULLME but without the query part
            $SCRIPT - relative me, like ME without wwwroot - ex: "/course/view.php", "/admin/cron.php"


            the cron should stop using FULLME == 'cron' and instead use $SCRIPT == "/$CFG->admin/cron.php"


            -------
            This is just the first step towards reversed proxy and SSL accel support ;-)
            This will also help with detection of incorrect access addresses.
            Hide
            Petr Skoda added a comment -

            done :-D

            Show
            Petr Skoda added a comment - done :-D
            Petr Skoda made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Martin Dougiamas made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            Martin Dougiamas made changes -
            Workflow jira [ 30085 ] MDL Workflow [ 61696 ]
            Martin Dougiamas made changes -
            Workflow MDL Workflow [ 61696 ] MDL Full Workflow [ 90895 ]

              People

              • Assignee:
                Petr Skoda
                Reporter:
                Petr Skoda
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: