Details
Minor
Description
The iCal export creates a new UID for each event each time the iCal feed is requested. That means that calendars that consume the iCal feed create a duplicate event each time they update from the feed. The UID should really be an identifier for the calendar event.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
I'm not convinced. What about two Moodles on the same server. Wouldn't $CFG->wwwroot be safer?
Good catch, fixed to now use wwwroot (with http:// and https:// stripped)
Looks good. Closing now.
That was quick! Thanks Martin and Tim!
Gustav
Nice to see you around Gustav! Cheers!
Yes this looks like a bad oversight.
Seems like $eventid@hostname should be enough.
This should fix it:
Index: export_execute.php
===================================================================
RCS file: /cvsroot/moodle/moodle/calendar/export_execute.php,v
retrieving revision 1.5.2.8
diff -c -r1.5.2.8 export_execute.php
***************
}
}
$ev = new iCalendar_event;
+ $ev->add_property('uid', $event->id.'@'.$_SERVER['HTTP_HOST']);
$ev->add_property('summary', $event->name);
$ev->add_property('description', $event->description);
$ev->add_property('class', 'PUBLIC'); // PUBLIC / PRIVATE / CONFIDENTIAL