Moodle
  1. Moodle
  2. MDL-17982

Security overview report backported to 1.9 uses 2.0 API

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 1.9.3
        • Fix Version/s: 1.9.4
        • Component/s: Administration
        • Labels:
          None
        • Environment:
          Spotted at PostgreSQL 8.3
        • Difficulty:
          Easy
        • Affected Branches:
          MOODLE_19_STABLE
        • Fixed Branches:
          MOODLE_19_STABLE
        • Rank:
          31575

          Description

          admin/report/security has been recently backported from HEAD to 19_STABLE. However, some code remained using new DB API returned values. Also, some links do not work in 1.9.

            Issue Links

            has been marked as being related by

            Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-17222 Security overview report

            • Minor - Minor loss of function where workaround is possible
            • Closed
            is duplicated by

            Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-18030 Missing admin/roles/define.php in 1.9.3 weekly

            • Major - Major loss of function, incorrect output
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              David Mudrak added a comment -

              Fixes:

              • admin/roles/manage.php instead of new admin/roles/define.php
              • results returned by old get_recordset_sql() must be iterated using rs_fetch_next_record() instead of new foreach()
              Show
              David Mudrak added a comment - Fixes: admin/roles/manage.php instead of new admin/roles/define.php results returned by old get_recordset_sql() must be iterated using rs_fetch_next_record() instead of new foreach()
              Hide
              Permalink
              David Mudrak added a comment -

              Fixed in CVS, please review and close

              Show
              David Mudrak added a comment - Fixed in CVS, please review and close
              Hide
              Permalink
              Petr Škoda added a comment -

              ooops, thanks going to review later today

              Show
              Petr Škoda added a comment - ooops, thanks going to review later today
              Hide
              Permalink
              Petr Škoda added a comment -

              thanks!

              Show
              Petr Škoda added a comment - thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: