Moodle
  1. Moodle
  2. MDL-18044

Notice from forum ratings and wrong add scale instructions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3
    • Fix Version/s: 1.9.4
    • Component/s: Forum
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      31569

      Description

      Notice: Undefined property: stdClass::$assesstimestart in /srv/www/htdocs/moodle_19/mod/forum/lib.php on line 3016 when you have ratings selected, but not using a scale.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          The wrong help text was on course/scales.php, which you get to by clicking the help icon next to Grade field on the forum settings form. (That page also had XHTML strict problems.)

          The notice came from turning on ratings by setting Aggregate type to something, but then leaving Grade on 'No grade'.

          Show
          Tim Hunt added a comment - The wrong help text was on course/scales.php, which you get to by clicking the help icon next to Grade field on the forum settings form. (That page also had XHTML strict problems.) The notice came from turning on ratings by setting Aggregate type to something, but then leaving Grade on 'No grade'.
          Hide
          Sam Hemelryk added a comment -

          Confirmed thanks Tim, everything looks good now

          Show
          Sam Hemelryk added a comment - Confirmed thanks Tim, everything looks good now
          Hide
          Anthony Borrow added a comment -

          Tim - FYI, I was looking at MDL-15463 which you had already fixed here; however, I noticed one instance where the old string was still being used which I suspect was just an oversight so I have changed that instance in course/scales.php to use scalestip2 instead of the older and inaccurate scaletip. Peace - Anthony

          Show
          Anthony Borrow added a comment - Tim - FYI, I was looking at MDL-15463 which you had already fixed here; however, I noticed one instance where the old string was still being used which I suspect was just an oversight so I have changed that instance in course/scales.php to use scalestip2 instead of the older and inaccurate scaletip. Peace - Anthony

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: