Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18095

Cannot clear override flag on grades with feedback

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Gradebook
    • Labels:
      None
    • Testing Instructions:
      Hide

      Make sure that your site has quick feedback turned on.

      Create an assignment activity. Online text is generally easiest.

      As a student complete the assignment.

      As a teacher or admin log in and grade the assignment. Provide some feedback when you do.

      Go to the gradebook, note that the grade and feedback appears in the gradebook (ie the grader report). You may see html tags in the feedback box. This is a known issue so please ignore it while testing this.

      Turn on editing and click the edit/hand icon for the grade item.

      Tick "Overridden", alter the grade, edit the feedback and click "save changes".

      Check that the feedback and grade was changed on the grader report.

      Click the edit icon again. Untick overriden and click save changes.

      Check that the grader report now shows the original grade and feedback.

      In the grade report change the grade and feedback and click "Update".

      Check that the feedback and grade were changed.

      Click the edit icon again. Untick overriden and click save changes.

      Check that the grader report now shows the original grade and feedback.

      Show
      Make sure that your site has quick feedback turned on. Create an assignment activity. Online text is generally easiest. As a student complete the assignment. As a teacher or admin log in and grade the assignment. Provide some feedback when you do. Go to the gradebook, note that the grade and feedback appears in the gradebook (ie the grader report). You may see html tags in the feedback box. This is a known issue so please ignore it while testing this. Turn on editing and click the edit/hand icon for the grade item. Tick "Overridden", alter the grade, edit the feedback and click "save changes". Check that the feedback and grade was changed on the grader report. Click the edit icon again. Untick overriden and click save changes. Check that the grader report now shows the original grade and feedback. In the grade report change the grade and feedback and click "Update". Check that the feedback and grade were changed. Click the edit icon again. Untick overriden and click save changes. Check that the grader report now shows the original grade and feedback.
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-18095-master-2

      Description

      To reproduce:

      -In the grader report, turn editing on and turn quick feedback on.
      -Enter some feedback and click update. Note that the grade is now overridden.
      -Click the edit icon above the grade, clear the overridden flag, and save changes. Note that the grade still shows as overridden and the feedback is now surrounded by paragraph tags.
      -Click the edit icon again, clear the overridden flag again, and save. Note that the override appears to be cleared now.
      -Enter a grade in any other cell and click update. Note that the grade that was previously cleared is now overridden once again.

      The only way I've found to really clear the overridden flag is to completely clear the feedback. It is sometimes necessary to go to html source view in the feedback editor and clear any html that might be left behind after the text is removed.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  9 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/12