Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: Installation
    • Labels:
      None
    • Database:
      Any
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Rank:
      35396

      Description

      When working in the Windows installer, I've detected that threre are some problems with back & forward slashes in the installer:

      dirroot is calculated with dirname() that uses "native" windows backslashes.
      dataroot is calculated with moodle stuff, that always use forwardslashes

      Later, dirroot is written with forwardslashes.

      And then, later, in admin/index.php, dirroot is checked again with realpath(), and that doesn't pass the test when comparing back & forward slashed dirroots.

      So I'm going to:

      0) After chat with Sam, use always forward-slashes seems to be ok.
      1) Change install to suggest forward-slashed dirroot.
      2) Change admin/index.php check to ignore back & forward slashes differences.

      Ciao

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        I've done 2) make the admin/index.php slash-insensitive

        Petr, do you have anything to do about 1) like calculate dirroot/dataroot always with forward-slashes?

        Or can we leave that, as far as config.php is always written with forward ones?

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - I've done 2) make the admin/index.php slash-insensitive Petr, do you have anything to do about 1) like calculate dirroot/dataroot always with forward-slashes? Or can we leave that, as far as config.php is always written with forward ones? Ciao
        Hide
        Petr Škoda added a comment -

        my +1 for always / everywhere

        Show
        Petr Škoda added a comment - my +1 for always / everywhere
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Oki going to implement 1) calculated dirrott/dataroot with forward-slashes

        Show
        Eloy Lafuente (stronk7) added a comment - Oki going to implement 1) calculated dirrott/dataroot with forward-slashes
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Done. Now all initial calculations + config.php write are always using forward slashes.

        Resolving as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Done. Now all initial calculations + config.php write are always using forward slashes. Resolving as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: