Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18226

Regression from MDL-17703: text "(Flash animation)" always visible

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 1.9.4
    • Fix Version/s: None
    • Component/s: Filters
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE

      Description

      Described in http://tracker.moodle.org/browse/MDL-17703?focusedCommentId=64077&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_64077

      Due to the changes made by patches 1.38.2.7 and 1.38.2.8 the text about flash player not installed on client's computer inside <span> is always displayed (the span has other id, so the text is not replaced by javascript). This caused regression to all pages, where swf, mp3 or flv files are inserted via media_plugin filter, not via resource. As I understand, when swf or mp3 resources are inserted into course, the media_plugin filter is not used. When the object is inserted via media_plugin, it is always inside <span>, is it allowed by XHTML strict? If it is, another <div> is not necessary.
      I propose to revert these patches and revise the problem of XHTML strict code in media objects.

      Screenshot attached

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dongsheng Dongsheng Cai
              Reporter:
              aav Artem Andreev
              Tester:
              Nobody Nobody
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: