Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18297

Reword date conditions and make meaning more natural

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Labels:
      None
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      Helen,

      Currently defined as - $string['requires_date_before']='Not available from $a.';

      It displays something like:

      Activity conditionally restricted: 'Not available until 17 March 2009.Not available from 20 March 2009.'

      Because of the phrasing of it not being available I think 'from' would read better if it were 'after' which is ironic considering the name of the string. That would produce:

      Activity conditionally restricted: 'Not available until 17 March 2009.Not available after 20 March 2009.'

      which I think makes more sense. I'll attach a patch.

      Looking at the string names, I wonder if we might want to consider making all of the Not available statements into the more positive available statements. That could produce something like:

      Activity conditionally restricted: 'Available beginning 17 March 2009. Available until 20 March 2009.' or
      Activity conditionally restricted: 'Available beginning 17 March 2009. Available before 20 March 2009.'

      I also noticed that the get_full_information function in conditionlib.php is not putting a space between the different conditions so we may want to end each of those with a space. This started out as a simple request to change a word but the more I looked at it the more ideas that came to mind. I'll stop for now

      Peace - Anthony

        Attachments

        1. MDL-18297_positive.diff
          3 kB
        2. MDL-18297.diff
          1 kB
        3. Screenshot-Assignment.png
          Screenshot-Assignment.png
          77 kB
        4. Screenshot-Course.png
          Screenshot-Course.png
          129 kB

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              aborrow Anthony Borrow
              Tester:
              Anthony Borrow
              Participants:
              Component watchers:
              Sam Marshall, Jake Dallimore, Jun Pataleta, Ryan Wyllie, cameron1729, David Mudrák (@mudrd8mz), Helen Foster
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: