Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.4, 2.0, 2.2.3, 2.3
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Gradebook, Quiz
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. Create a quiz and untick 'marks' in Review settings
      2. Create a new assignment
      3. Login as the student, attempt the quiz and assignment
      4. Go to the gradebook and make sure you do not see your grade
      5. Login as an admin, go to the gradebook and turn editing on.
      6. Give a grade on the assignment of the student
      7. Click on the edit button right below the quiz name
      8. Make sure you can't update the 'hidden' status, and that it displays 'Whether this grade item is hidden is controlled by the activity settings.'
      9. Click on the edit button right under the assignment name
      10. Make sure:

      • You can tick/untick 'hidden' for this grade
      • If you tick it, the student do not see the grade in his gradebook
      • If you untick it, the student can see his grade

      11. As an admin, go to the quiz settings and tick the 'Mark' checkbox
      12. As a student, make sure you now can see your grade in the gradebook

      Show
      1. Create a quiz and untick 'marks' in Review settings 2. Create a new assignment 3. Login as the student, attempt the quiz and assignment 4. Go to the gradebook and make sure you do not see your grade 5. Login as an admin, go to the gradebook and turn editing on. 6. Give a grade on the assignment of the student 7. Click on the edit button right below the quiz name 8. Make sure you can't update the 'hidden' status, and that it displays 'Whether this grade item is hidden is controlled by the activity settings.' 9. Click on the edit button right under the assignment name 10. Make sure: You can tick/untick 'hidden' for this grade If you tick it, the student do not see the grade in his gradebook If you untick it, the student can see his grade 11. As an admin, go to the quiz settings and tick the 'Mark' checkbox 12. As a student, make sure you now can see your grade in the gradebook
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-18301-master

      Description

      When you attempt to hide the grades of a quiz, the "hidden" checkbox does not stay checked even after saving.

      How to reproduce.

      1. With a course which has a quiz, go to the gradebook
      2. Turn editing on and click the edit button under the quiz to edit the quiz grade item.
      3. Check the "Hidden" checkbox
      4. Save changes
      5. Click on the edit button again to verify whether the setting was actually saved or not.

      You will see that it doesn't save. I reproduced this on our own installation as well as the demo.moodle.org installation.

        Gliffy Diagrams

        1. MDL-18301_2.patch
          1 kB
          Nicolas Connault
        2. MDL-18301.patch
          3 kB
          Nicolas Connault

          Issue Links

            Activity

            Hide
            tsala Helen Foster added a comment -

            David, thanks for your report with clear steps of how to reproduce the problem.

            I can confirm that it remains a problem in 1.9.4+.

            Setting a fix version of 1.9.5 in the hope that it can be fixed soon.

            Show
            tsala Helen Foster added a comment - David, thanks for your report with clear steps of how to reproduce the problem. I can confirm that it remains a problem in 1.9.4+. Setting a fix version of 1.9.5 in the hope that it can be fixed soon.
            Hide
            nicolasconnault Nicolas Connault added a comment -

            Just attached a proposed patch (MDL-18301.patch)

            Show
            nicolasconnault Nicolas Connault added a comment - Just attached a proposed patch ( MDL-18301 .patch)
            Hide
            nicolasconnault Nicolas Connault added a comment -

            Attached a differenty formatted version of the patch

            Show
            nicolasconnault Nicolas Connault added a comment - Attached a differenty formatted version of the patch
            Hide
            skodak Petr Skoda added a comment -

            I do not think this is a good long term solution for 2.0, the reason is we should be moving all grading related settings and functions into gradebook.

            Show
            skodak Petr Skoda added a comment - I do not think this is a good long term solution for 2.0, the reason is we should be moving all grading related settings and functions into gradebook.
            Hide
            mjollnir Penny Leach added a comment -

            We need to fix it in 1.9 as well as 2.0, Petr

            Show
            mjollnir Penny Leach added a comment - We need to fix it in 1.9 as well as 2.0, Petr
            Hide
            nicolasconnault Nicolas Connault added a comment - - edited

            Attached unified diff: MDL-18301.patch
            CVS commit message: Preventing the quiz module from modifying its grade item's settings each time the gradebook attempts to change them (in essence, giving the gradebook priority over the grade item settings).

            Show
            nicolasconnault Nicolas Connault added a comment - - edited Attached unified diff: MDL-18301 .patch CVS commit message: Preventing the quiz module from modifying its grade item's settings each time the gradebook attempts to change them (in essence, giving the gradebook priority over the grade item settings).
            Hide
            nicolasconnault Nicolas Connault added a comment -

            From discussion in HQ chat:

            timhunt: The trouble is Nico, it was designed to work that way for a reason. When you create a quiz and intentionally set the grades to be hidden from students, then it was a feature requested in the original gradebook spec that the grade item should automatically be hidden in the gradebook.

            Show
            nicolasconnault Nicolas Connault added a comment - From discussion in HQ chat: timhunt: The trouble is Nico, it was designed to work that way for a reason. When you create a quiz and intentionally set the grades to be hidden from students, then it was a feature requested in the original gradebook spec that the grade item should automatically be hidden in the gradebook.
            Hide
            nicolasconnault Nicolas Connault added a comment -

            then the hidden controls should be disabled in the gradebook, and a link to the quiz module form given. Currently it appears horridly buggy from the gradebook's point of view.

            Show
            nicolasconnault Nicolas Connault added a comment - then the hidden controls should be disabled in the gradebook, and a link to the quiz module form given. Currently it appears horridly buggy from the gradebook's point of view.
            Hide
            mblake Michael Blake added a comment -

            Received a request from Moodle Partner (Miguel Santos @ Moodlerooms) to raise the priority on this. No activity for a few months. Nico, you state the feature looks horribly buggy - what's required to fix?

            Show
            mblake Michael Blake added a comment - Received a request from Moodle Partner (Miguel Santos @ Moodlerooms) to raise the priority on this. No activity for a few months. Nico, you state the feature looks horribly buggy - what's required to fix?
            Hide
            cttxg Teresa Gibbison added a comment -

            I have also noticed similar results when we edit the quiz activity itself, to reproduce

            1. With a course which has a quiz, go to the gradebook
            2. Turn editing on and click the edit button under the quiz to edit the quiz grade item.
            3. Check the "Hidden" checkbox
            4. Save changes
            5. Go back to the quiz activity and update the settings - in our case we were adding a new password.
            6. Go back to the gradebook - the quiz grade item is now available

            Show
            cttxg Teresa Gibbison added a comment - I have also noticed similar results when we edit the quiz activity itself, to reproduce 1. With a course which has a quiz, go to the gradebook 2. Turn editing on and click the edit button under the quiz to edit the quiz grade item. 3. Check the "Hidden" checkbox 4. Save changes 5. Go back to the quiz activity and update the settings - in our case we were adding a new password. 6. Go back to the gradebook - the quiz grade item is now available
            Hide
            cttxg Teresa Gibbison added a comment -

            Our current workaround = putting the hidden grade item into a hidden grade category. The students will not be able to view the item regardless of it's show/hide status because the category it belongs to is hidden.
            I hope this helps anyone waiting for the fix!
            Cheers
            Teresa

            Show
            cttxg Teresa Gibbison added a comment - Our current workaround = putting the hidden grade item into a hidden grade category. The students will not be able to view the item regardless of it's show/hide status because the category it belongs to is hidden. I hope this helps anyone waiting for the fix! Cheers Teresa
            Hide
            susane susan e added a comment -

            an annoying but workable way to fix this problem from the users perspective.
            go into the gradebook
            turn editing on
            click the edit button for a quiz
            click the disable button right under the hidden check box
            click the disable button right under the locked check box
            save
            the hidden setting will no longer be in effect and the quiz will be viewable

            Show
            susane susan e added a comment - an annoying but workable way to fix this problem from the users perspective. go into the gradebook turn editing on click the edit button for a quiz click the disable button right under the hidden check box click the disable button right under the locked check box save the hidden setting will no longer be in effect and the quiz will be viewable
            Hide
            tsala Helen Foster added a comment -

            Thanks everyone for your comments. Not quite sure where we are with this issue, however I've just added gradebook expert Andrew as watcher for his consideration.

            Show
            tsala Helen Foster added a comment - Thanks everyone for your comments. Not quite sure where we are with this issue, however I've just added gradebook expert Andrew as watcher for his consideration.
            Hide
            timhunt Tim Hunt added a comment -

            Note Petr's comment above that Nico's patches are the wrong approach. Note also that MDL-13978 is probably related.

            Andrew, I would like it if someone could give me a clear answer as to how modules are supposed to interact with the gradebook. And if there is not a clear answer yet, please can we work one out for Moodle 2.1? Thanks.

            Show
            timhunt Tim Hunt added a comment - Note Petr's comment above that Nico's patches are the wrong approach. Note also that MDL-13978 is probably related. Andrew, I would like it if someone could give me a clear answer as to how modules are supposed to interact with the gradebook. And if there is not a clear answer yet, please can we work one out for Moodle 2.1? Thanks.
            Hide
            timhunt Tim Hunt added a comment -

            Removing the patch label, since the patches here do not seem to be useful, and I am trying to concentrate on all the quiz bugs with useful patches.

            Show
            timhunt Tim Hunt added a comment - Removing the patch label, since the patches here do not seem to be useful, and I am trying to concentrate on all the quiz bugs with useful patches.
            Show
            moodle.com moodle.com added a comment - Related: http://docs.moodle.org/en/Development:Gradebook_2.x_architecture
            Hide
            fred Frédéric Massart added a comment - - edited

            Discussing about this issue with Tim yesterday helped me to understand what happened here. This morning, I have investigated a little more, I was looking if having a hook in the quiz could, for example, display a message to tell users that the hidden status is handled by the quiz itself. But then I noticed that this is not true! The hook to update the hidden state from the quiz is called when we update the 'locked' status. And only when the lock status is not set. Which means that if a teacher hides the grades in the quiz, he can still show them in the gradebook if he locks them. Is that an expected behaviour?

            Time estimated: 8 hours

            Show
            fred Frédéric Massart added a comment - - edited Discussing about this issue with Tim yesterday helped me to understand what happened here. This morning, I have investigated a little more, I was looking if having a hook in the quiz could, for example, display a message to tell users that the hidden status is handled by the quiz itself. But then I noticed that this is not true! The hook to update the hidden state from the quiz is called when we update the 'locked' status. And only when the lock status is not set. Which means that if a teacher hides the grades in the quiz, he can still show them in the gradebook if he locks them. Is that an expected behaviour? Time estimated: 8 hours
            Hide
            timhunt Tim Hunt added a comment -

            I don't think anyone could possibly expect exactly that behaviour!

            I think bits of what you are seeing are actually other bugs, in particular MDL-13978 (LOL my last comment there from Dec 2008) and MDL-14119.

            Are you prepared to expand the scope of what you are doing to include those?

            Really, there is a fundamental problem with the gradebook, which can be reduced to the following question:

            What is the expected behaviour in this scenario?

            1. Student makes first attempt at a quiz. (The grade goes into the gradebook.)
            2. Teacher manually edits the grade in the gradebook.
            3. Student makes a second attempt at the quiz and gets a higher mark.

            Presumably either we over-write the teacher's manual edit, or we ignore the student's second attempt. Both are bad.

            There is why there has been a lot of talk about whether the internals of the gradebook are exactly right. Perhaps the way out of this dilemma is to have it so that we can show both the 'automatically computed grade' and the 'final grade' for each item. (There are similar problem scenarios with calculated columns). Really, we need to do a detailed review of the grade-book data model, in light of the these tricky edge cases, and tweak it. That would let us better represent what is really going on in the database, and thus also make what is going on clearer in the UI.

            In fact, this would be a really good topic to discuss at the hack-fest in October, and it would be great if some HQ people (other than Petr, who used to work on a lot of these bugs, but then got pissed off with the whole thing) got to understand more about the gradebook before then. My suggestion would be that over the next few months, you try to fix a range of gradebook bugs as well as possible given the current data structures. Then we can have a really good informed debate in October about what the right long term solution is.

            Well, that is my advice considering what is best for Moodle. If I had your best interests at heart I should probably be advising you to run screaming from the room while your sanity is still intact

            Show
            timhunt Tim Hunt added a comment - I don't think anyone could possibly expect exactly that behaviour! I think bits of what you are seeing are actually other bugs, in particular MDL-13978 (LOL my last comment there from Dec 2008) and MDL-14119 . Are you prepared to expand the scope of what you are doing to include those? Really, there is a fundamental problem with the gradebook, which can be reduced to the following question: What is the expected behaviour in this scenario? 1. Student makes first attempt at a quiz. (The grade goes into the gradebook.) 2. Teacher manually edits the grade in the gradebook. 3. Student makes a second attempt at the quiz and gets a higher mark. Presumably either we over-write the teacher's manual edit, or we ignore the student's second attempt. Both are bad. There is why there has been a lot of talk about whether the internals of the gradebook are exactly right. Perhaps the way out of this dilemma is to have it so that we can show both the 'automatically computed grade' and the 'final grade' for each item. (There are similar problem scenarios with calculated columns). Really, we need to do a detailed review of the grade-book data model, in light of the these tricky edge cases, and tweak it. That would let us better represent what is really going on in the database, and thus also make what is going on clearer in the UI. In fact, this would be a really good topic to discuss at the hack-fest in October, and it would be great if some HQ people (other than Petr, who used to work on a lot of these bugs, but then got pissed off with the whole thing) got to understand more about the gradebook before then. My suggestion would be that over the next few months, you try to fix a range of gradebook bugs as well as possible given the current data structures. Then we can have a really good informed debate in October about what the right long term solution is. Well, that is my advice considering what is best for Moodle. If I had your best interests at heart I should probably be advising you to run screaming from the room while your sanity is still intact
            Hide
            timhunt Tim Hunt added a comment -

            Just to summarise what Fred and I discussed before. We can think of two possible solutions to this that could be done now. (There are other solutions that would only be possible by changing the inner workings of the gradebook, which would make this a big change.)

            1. Remove the option to explicitly show/hide the quiz grade in the gradebook, and replace it with a message / tool-tip that says "the visibility of this grade is controlled by the quiz settings."

            2. Decouple the visibility of the grade item from the quiz setting that controls visibility of grades within the quiz activity. (So that people who need them to be synchronised would have to remember to change both settings at the same time when they want to show/hide grades).

            Oh, and I have thought of a third option just now.

            3. Break the link, in 2., but then add a cron job in the quiz module which automatically updates the visibility of the grade item when the quiz close date passes. That would keep the synchronisation (although with a short delay) but would not cause mystifying changes in grade item visibility whenever the quiz updates a grade in the gradebook. This would probably require an additional quiz setting: Automatically show/hide the associated grade item [yes / no] (Advanced). Saving the quiz form (which might change review options, open or close dates, would also need to update the grade item if this setting was on.)

            I will see if people at the OU have strong opinions about this.

            Show
            timhunt Tim Hunt added a comment - Just to summarise what Fred and I discussed before. We can think of two possible solutions to this that could be done now. (There are other solutions that would only be possible by changing the inner workings of the gradebook, which would make this a big change.) 1. Remove the option to explicitly show/hide the quiz grade in the gradebook, and replace it with a message / tool-tip that says "the visibility of this grade is controlled by the quiz settings." 2. Decouple the visibility of the grade item from the quiz setting that controls visibility of grades within the quiz activity. (So that people who need them to be synchronised would have to remember to change both settings at the same time when they want to show/hide grades). Oh, and I have thought of a third option just now. 3. Break the link, in 2., but then add a cron job in the quiz module which automatically updates the visibility of the grade item when the quiz close date passes. That would keep the synchronisation (although with a short delay) but would not cause mystifying changes in grade item visibility whenever the quiz updates a grade in the gradebook. This would probably require an additional quiz setting: Automatically show/hide the associated grade item [yes / no] (Advanced). Saving the quiz form (which might change review options, open or close dates, would also need to update the grade item if this setting was on.) I will see if people at the OU have strong opinions about this.
            Hide
            fred Frédéric Massart added a comment -

            Hi Tim,

            I would personally give my +1 for the first option. Easy to understand and to work with.
            Should we post on the forums to gather people's opinion about those 3 options?

            Show
            fred Frédéric Massart added a comment - Hi Tim, I would personally give my +1 for the first option. Easy to understand and to work with. Should we post on the forums to gather people's opinion about those 3 options?
            Hide
            timhunt Tim Hunt added a comment -

            If you are happy to implement 1, then I think that is a good short-term fix for now.

            However, in an open source world, you can't just assume you know best. (I have certainly been surprised how often other community members have been able to save me from doing something stupid.) So I would suggest you make a short post in the gradebook forum, just giving this bug id, and saying what we propose to do, and that if anyone is concerned about that they should comment here.

            However, I am quite confident that 1. is a reasonable solution, so you could start writing the code without waiting for a response in the forum.

            Show
            timhunt Tim Hunt added a comment - If you are happy to implement 1, then I think that is a good short-term fix for now. However, in an open source world, you can't just assume you know best. (I have certainly been surprised how often other community members have been able to save me from doing something stupid.) So I would suggest you make a short post in the gradebook forum, just giving this bug id, and saying what we propose to do, and that if anyone is concerned about that they should comment here. However, I am quite confident that 1. is a reasonable solution, so you could start writing the code without waiting for a response in the forum.
            Hide
            andyjdavis Andrew Davis added a comment - - edited

            Definitely post this in the forums. Possibly even before you do that, write a document specifying the code changes involved. That way you have somewhere neat to send interested people and the description of the current proposed solution is clearly separated from the discussion of all past proposed solutions.

            Show
            andyjdavis Andrew Davis added a comment - - edited Definitely post this in the forums. Possibly even before you do that, write a document specifying the code changes involved. That way you have somewhere neat to send interested people and the description of the current proposed solution is clearly separated from the discussion of all past proposed solutions.
            Hide
            fred Frédéric Massart added a comment -

            Hi Tim, I have posted on the forum and pushed a patch. I have set you as peer reviewer as we discussed quite a lot about this issue already. I've only patched for master for now, but I guess I could backport it up to 2.2 once it'll pass your review.

            Show
            fred Frédéric Massart added a comment - Hi Tim, I have posted on the forum and pushed a patch. I have set you as peer reviewer as we discussed quite a lot about this issue already. I've only patched for master for now, but I guess I could backport it up to 2.2 once it'll pass your review.
            Hide
            timhunt Tim Hunt added a comment -

            The code is pretty good, but some issues:

            0. (This is nothing to do with your change, but the // advcheckbox is not compatible with disabledIf! is out of date, so the code could be changed, but now is not really the time.)

            1. I think the string "The visibility of the grades is managed in the settings of this activity" makes sense to us as developers, but I worry it is not written in user's language. I would try asking Helen about this.

            2. I don't think you should write your own can_control_visibility method and require plugins to add a new callback

            {x}

            _controls_grade_visibility. Just use plugin_supports from moodlelib.php.

            3. I don't think you should be calling the moodlelib function and then catching an exception in the common case when the grade_item type and module do not make a valid plugin name. Instead, I would do something like

            public function can_control_visibility() {
                if (get_plugin_directory($this->itemtype, $this->itemmodule)) {
                    return plugin_supports($this->itemtype, $this->itemmodule, FEATURE_CONTROLS_GRADE_VISIBILITY);
                }
                return true;
            }    

            (It is not great to use get_plugin_directory when what I mean is does_plugin_exist, but there is no method with a name like does_plugin_exist.)

            4. No need for a cache here. Performance is not that critical, so the extra complexity is a poor trade-off.

            Show
            timhunt Tim Hunt added a comment - The code is pretty good, but some issues: 0. (This is nothing to do with your change, but the // advcheckbox is not compatible with disabledIf! is out of date, so the code could be changed, but now is not really the time.) 1. I think the string "The visibility of the grades is managed in the settings of this activity" makes sense to us as developers, but I worry it is not written in user's language. I would try asking Helen about this. 2. I don't think you should write your own can_control_visibility method and require plugins to add a new callback {x} _controls_grade_visibility. Just use plugin_supports from moodlelib.php. 3. I don't think you should be calling the moodlelib function and then catching an exception in the common case when the grade_item type and module do not make a valid plugin name. Instead, I would do something like public function can_control_visibility() { if (get_plugin_directory($this->itemtype, $this->itemmodule)) { return plugin_supports($this->itemtype, $this->itemmodule, FEATURE_CONTROLS_GRADE_VISIBILITY); } return true; } (It is not great to use get_plugin_directory when what I mean is does_plugin_exist, but there is no method with a name like does_plugin_exist.) 4. No need for a cache here. Performance is not that critical, so the extra complexity is a poor trade-off.
            Hide
            timhunt Tim Hunt added a comment -

            I never remember to click the peer review buttons when commenting.

            Show
            timhunt Tim Hunt added a comment - I never remember to click the peer review buttons when commenting.
            Hide
            fred Frédéric Massart added a comment -

            Thanks Tim! I was not aware of plugin_supports(), that is in fact much better to use. I have updated the patch for points 2 to 4.

            I'll poke Helen about the sentence and push for peer review again when the patch will be complete.

            Show
            fred Frédéric Massart added a comment - Thanks Tim! I was not aware of plugin_supports(), that is in fact much better to use. I have updated the patch for points 2 to 4. I'll poke Helen about the sentence and push for peer review again when the patch will be complete.
            Hide
            tsala Helen Foster added a comment -

            Hi Fred,

            Thanks for asking for my suggestion for the new lang string and apologies for my delay in replying. Anyway, I'd suggest

            'The review options in the quiz settings determine if and when grades are hidden.'

            For the benefit of anyone else reading this issue, just noting that the proposed solution is for the hidden setting on the edit grade item page to be replaced by the componentcontrolsvisibility lang string.

            PS Here's a link to Fred's forum post in the quiz module forum: http://moodle.org/mod/forum/discuss.php?d=206015

            Show
            tsala Helen Foster added a comment - Hi Fred, Thanks for asking for my suggestion for the new lang string and apologies for my delay in replying. Anyway, I'd suggest 'The review options in the quiz settings determine if and when grades are hidden.' For the benefit of anyone else reading this issue, just noting that the proposed solution is for the hidden setting on the edit grade item page to be replaced by the componentcontrolsvisibility lang string. PS Here's a link to Fred's forum post in the quiz module forum: http://moodle.org/mod/forum/discuss.php?d=206015
            Hide
            tsala Helen Foster added a comment -

            Tim has just pointed out to me that the lang string may be used by other activity modules, such as contrib modules. Thus my revised suggestion is

            'Activity settings control if and when grades are hidden.'

            Show
            tsala Helen Foster added a comment - Tim has just pointed out to me that the lang string may be used by other activity modules, such as contrib modules. Thus my revised suggestion is 'Activity settings control if and when grades are hidden.'
            Hide
            timhunt Tim Hunt added a comment -

            Or perhaps

            Whether this grade item is hidden is controlled by the activity settings.

            Show
            timhunt Tim Hunt added a comment - Or perhaps Whether this grade item is hidden is controlled by the activity settings.
            Hide
            tsala Helen Foster added a comment -

            Thanks Tim, I like your suggestion the best.

            Show
            tsala Helen Foster added a comment - Thanks Tim, I like your suggestion the best.
            Hide
            fred Frédéric Massart added a comment -

            There you go Tim. I have updated the sentence and created the branches for 2.2 and 2.3. Cheers!

            Show
            fred Frédéric Massart added a comment - There you go Tim. I have updated the sentence and created the branches for 2.2 and 2.3. Cheers!
            Hide
            timhunt Tim Hunt added a comment -

            +1 from me. Thank you.

            Show
            timhunt Tim Hunt added a comment - +1 from me. Thank you.
            Hide
            poltawski Dan Poltawski added a comment -

            Great work everyone on getting a pragmatic solution to this.

            I've integrated this now. Tim, do you know if there is a good place to document the feature_supports constant? (I can't think of a place).

            Show
            poltawski Dan Poltawski added a comment - Great work everyone on getting a pragmatic solution to this. I've integrated this now. Tim, do you know if there is a good place to document the feature_supports constant? (I can't think of a place).
            Hide
            poltawski Dan Poltawski added a comment -

            BTW: Tim: you removed the 'stable sprint 21' fix version. I've done this myself accidentally many times. Please keep it in as its used to track the stable teams sprints (fred will not be able to talk about it at his standup!).

            Show
            poltawski Dan Poltawski added a comment - BTW: Tim: you removed the 'stable sprint 21' fix version. I've done this myself accidentally many times. Please keep it in as its used to track the stable teams sprints (fred will not be able to talk about it at his standup!).
            Hide
            timhunt Tim Hunt added a comment -

            I think the only place the FEATURE_ constants are documented is in the PHPdoc comments at the top of moodlelib.php. That seems to be exactly right to me.

            I did not know about the sprint fix versions.

            Show
            timhunt Tim Hunt added a comment - I think the only place the FEATURE_ constants are documented is in the PHPdoc comments at the top of moodlelib.php. That seems to be exactly right to me. I did not know about the sprint fix versions.
            Hide
            dmonllao David Monllaó added a comment -

            Tested in 2.2 and 2.3. It passes

            Show
            dmonllao David Monllaó added a comment - Tested in 2.2 and 2.3. It passes
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations!

            You've made it into the weekly release!

            Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
            http://www.youtube.com/watch?v=_QhpHUmVCmY

            Show
            poltawski Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY
            Hide
            andyjdavis Andrew Davis added a comment -

            There are an interconnected set of issues that probably need to be considered as a unit.

            MDL-38383
            MDL-31487
            MDL-38445
            MDL-18301 (this is actually closed but was recently fixed and is relevant)

            Show
            andyjdavis Andrew Davis added a comment - There are an interconnected set of issues that probably need to be considered as a unit. MDL-38383 MDL-31487 MDL-38445 MDL-18301 (this is actually closed but was recently fixed and is relevant)
            Hide
            timhunt Tim Hunt added a comment -

            This bug fix was not complete. There were regressions, which I am about to fix in MDL-31487.

            Show
            timhunt Tim Hunt added a comment - This bug fix was not complete. There were regressions, which I am about to fix in MDL-31487 .

              People

              • Votes:
                17 Vote for this issue
                Watchers:
                16 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12