Moodle
  1. Moodle
  2. MDL-18395

Change review 'Immediately after the attempt' to use session, rather than an arbitrary timeout

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Quiz
    • Labels:
      None
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      15347

      Description

      On submit all and finish, initialise

      $SESSION->quizattemptjustfinished[$attemtp->id] = array('key' => random_string(10), 'time' => time());

      and add

      ?key=$SESSION->quizattemptjustfinished[$attemtp->id]['key'];

      to the URL of the review page. That marks that this is a review 'immediately after the attempt'. On each hit of the review page, update the 'time'.

      Then on 'Finish review', delete that entry from quizattemptjustfinished.

      When validating the key, if too much time has passed since the last recorded 'time', delete this entry from quizattemptjustfinished - that is necessary for when people just close the browser window.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Idea from Oleg, on the review page, send a small ajax request every minute to keep the review alive. That is what the OU wiki does with the editing lock, I think. Seems like a good idea to me.

          Show
          Tim Hunt added a comment - Idea from Oleg, on the review page, send a small ajax request every minute to keep the review alive. That is what the OU wiki does with the editing lock, I think. Seems like a good idea to me.
          Hide
          Wen Hao Chuang added a comment -

          +1 for this

          Show
          Wen Hao Chuang added a comment - +1 for this
          Hide
          Tim Hunt added a comment -

          This is still a good idea, but I won't have time to do it before 2.0.

          Show
          Tim Hunt added a comment - This is still a good idea, but I won't have time to do it before 2.0.
          Hide
          Tim Hunt added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Tim Hunt added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            People

            • Votes:
              5 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated: