Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18474

global search should use of PATH_SEPARATOR

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.9.5, 2.0
    • Component/s: Global search
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      The scripts in the global search folder contain several instances of the following code:

      $separator = (array_key_exists('WINDIR', $_SERVER)) ? ';' : ':' ;
      ini_set('include_path', $CFG->dirroot.'\search'.$separator.ini_get('include_path'));

      But it seems unnecessary when we should use the PATH_SEPARATOR instead:

      ini_set('include_path', $CFG->dirroot.'\search'.PATH_SEPARATOR.ini_get('include_path'));

      Scripts affected:

      • search/add.php
      • search/delete.php
      • search/indexer.php
      • search/indexersplash.php
      • search/update.php
      • search/tests/index.php

        Attachments

          Activity

            People

            Assignee:
            vf Valery Fremaux
            Reporter:
            xxxxxxx Gordon Bateson
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/May/09