Moodle
  1. Moodle
  2. MDL-18482

Restore XML parsing: Improve for speed by skipping non-selected modules

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.9.5
    • Component/s: Backup
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      36699

      Description

      Right now, when a course is restored... no matter of the activities selected to be restored, the whole <MODULES> part of the backup file is parsed and all modules are xmlized.

      This is an excess of processing. Try to optimise it by being more selective... ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Resolving as fixed.

          Now, activities that have been not selected to be restored, aren't processed anymore avoiding previous excess of process, iow, speed gain.

          Note that, as side effect, this causes that in some course restores breaking previously, now it's possible to workaround the problem by restoring over the same course multiple times, selecting different activities on each restore until complete the whole set (this can help to MDL-15489 until proper fix is committed for it).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Resolving as fixed. Now, activities that have been not selected to be restored, aren't processed anymore avoiding previous excess of process, iow, speed gain. Note that, as side effect, this causes that in some course restores breaking previously, now it's possible to workaround the problem by restoring over the same course multiple times, selecting different activities on each restore until complete the whole set (this can help to MDL-15489 until proper fix is committed for it). Ciao
          Hide
          Petr Škoda added a comment -

          reviewed and tested, everything seems to work fine, thanks!

          Show
          Petr Škoda added a comment - reviewed and tested, everything seems to work fine, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: