Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18592

Allow teacher to make choices for students

    Details

    • Type: Improvement
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.9.5, 2.8.2
    • Fix Version/s: None
    • Component/s: Choice
    • Labels:
    • Environment:
      All
    • Database:
      Any
    • Testing Instructions:
      Hide

      Test 1

      1. Create a choice activity with multiple responses allowed
      2. Complete choice by several students, modify answers
      3. Login as teacher, go to "View responses" inside the choice activity
      4. Make sure you are able to modify and delete choices of students
      5. Go to choice settings and select to display results with names
      6. Now as a teacher you should be able to modify and delete choices on view page as well
      7. View choice logs and make sure all actions are logged. Changing of the answer should be logged as two events: answer removed and answer added
      8. Make sure students are not able to modify or delete answers of other students and don't see controls for it.

      Test 2 - logs upgrade

      1. On another instance of 3.1 (without changes from this issue) create a course
      2. Create a choice activity with multiple responses allowed
      3. Complete choice by several students, modify answers, allow teacher to delete some answers
      4. View logs for this activity and leave the page open
      5. In another window backup the course with user data and logs
      6. Restore the backup on upgraded site
      7. View the logs and make sure they are displayed the same (except that event "Choice made" became "Choice answer added")
      Show
      Test 1 Create a choice activity with multiple responses allowed Complete choice by several students, modify answers Login as teacher, go to "View responses" inside the choice activity Make sure you are able to modify and delete choices of students Go to choice settings and select to display results with names Now as a teacher you should be able to modify and delete choices on view page as well View choice logs and make sure all actions are logged. Changing of the answer should be logged as two events: answer removed and answer added Make sure students are not able to modify or delete answers of other students and don't see controls for it. Test 2 - logs upgrade On another instance of 3.1 (without changes from this issue) create a course Create a choice activity with multiple responses allowed Complete choice by several students, modify answers, allow teacher to delete some answers View logs for this activity and leave the page open In another window backup the course with user data and logs Restore the backup on upgraded site View the logs and make sure they are displayed the same (except that event "Choice made" became "Choice answer added")
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      wip-MDL-18592-master

      Description

      I've written code to allow a teacher to assign students who have not responded to a Choice option.

      See discussion: http://moodle.org/mod/forum/discuss.php?d=118914

      Code and screenshots will be posted in the next day or so.

        Gliffy Diagrams

        1. install.txt
          2 kB
          Brian Gray
        2. selectfor.php
          13 kB
          Brian Gray
        3. selectfor.v2.0.php
          13 kB
          Brian Gray
        4. SelectForDemo.pdf
          409 kB
          Brian Gray

          Issue Links

            Activity

            Hide
            bgray Brian Gray added a comment -

            Most of the new code is in file selectfor.php.

            Minor modifications are required to 4 other files. See install.txt.

            The PDF file includes screenshots with notes on functionality.

            Show
            bgray Brian Gray added a comment - Most of the new code is in file selectfor.php. Minor modifications are required to 4 other files. See install.txt. The PDF file includes screenshots with notes on functionality.
            Hide
            bgray Brian Gray added a comment -

            Revised version of selectfor.php

            Eliminates some bad code – I used a call to get_records_sql() that was not needed and would cause problems on non-standard installations.

            Show
            bgray Brian Gray added a comment - Revised version of selectfor.php Eliminates some bad code – I used a call to get_records_sql() that was not needed and would cause problems on non-standard installations.
            Hide
            bgray Brian Gray added a comment -

            selectfor.v2.0.php is the version of the file for Moodle 2.0. It should be renamed to selectfor.php and then installed with the same instructions as for 1.9.4.

            Show
            bgray Brian Gray added a comment - selectfor.v2.0.php is the version of the file for Moodle 2.0. It should be renamed to selectfor.php and then installed with the same instructions as for 1.9.4.
            Hide
            bgray Brian Gray added a comment -

            Updates to eliminate some PHP warnings and other code cleanup.

            If all users have responded (and therefore there are none to select for) the "Save" and "Randomly assign" buttons do not appear.

            files for 1.9.4 and 2.0 have been updated.

            Show
            bgray Brian Gray added a comment - Updates to eliminate some PHP warnings and other code cleanup. If all users have responded (and therefore there are none to select for) the "Save" and "Randomly assign" buttons do not appear. files for 1.9.4 and 2.0 have been updated.
            Hide
            danmarsden Dan Marsden added a comment -

            Unassigning myself from this as I am not planning to work on this and to allow someone else to pick this up.

            Show
            danmarsden Dan Marsden added a comment - Unassigning myself from this as I am not planning to work on this and to allow someone else to pick this up.
            Hide
            marina Marina Glancy added a comment - - edited

            This is some my weekend activity, this issue is not currently on the HQ roadmap but I thought it could be a nice step forward allowing students to help teacher to allocate them into groups (see MDL-13962)

            Show
            marina Marina Glancy added a comment - - edited This is some my weekend activity, this issue is not currently on the HQ roadmap but I thought it could be a nice step forward allowing students to help teacher to allocate them into groups (see MDL-13962 )
            Show
            cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: https://github.com/marinaglancy/moodle master (8 errors / 1 warnings) [branch: wip-MDL-18592-master | CI Job ] phplint (0/0) , phpcs (8/0) , js (0/0) , css (0/0) , phpdoc (0/1) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report

              People

              • Votes:
                21 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated: