Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18592

Allow teacher to make choices for students

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      Set debugging mode on

      Test 1

      1. Create a choice activity with multiple responses allowed
      2. Complete choice by several students, modify answers
      3. Login as teacher, go to "View responses" inside the choice activity
      4. Make sure you are able to modify and delete choices of students
      5. Go to choice settings and select to display results with names
      6. Now as a teacher you should be able to modify and delete choices on view page as well
      7. View choice logs and make sure all actions are logged. Changing of the answer should be logged as two events: answer removed and answer added
      8. Make sure students are not able to modify or delete answers of other students and don't see controls for it.
      9. Add access restrictions to the choice activity
      10. As a teacher make sure that the list of not answered users does not display users who can not access activity

      Test 2 - logs upgrade

      1. On another instance of 3.1 (without changes from this issue) create a course
      2. Create a choice activity with multiple responses allowed
      3. Complete choice by several students, modify answers, allow teacher to delete some answers
      4. View logs for this activity and leave the page open
      5. In another window backup the course with user data and logs
      6. Restore the backup on upgraded site
      7. In the final restore page, where you see the progress bar, open the browser code inspector and locate #executionprogress DOM node, check its contents, there should not be any debugging message
      8. View the logs and make sure they are displayed the same
      9. Inspect report "Events list" - events "Choice made" and "Choice updated" should be listed as "(no longer used)"
      10. Create new event monitor rule - you should not be able to subscribe to these two events but should be able to subscribe to "Choice answer added" and "Choice answer deleted"
      Show
      Set debugging mode on Test 1 Create a choice activity with multiple responses allowed Complete choice by several students, modify answers Login as teacher, go to "View responses" inside the choice activity Make sure you are able to modify and delete choices of students Go to choice settings and select to display results with names Now as a teacher you should be able to modify and delete choices on view page as well View choice logs and make sure all actions are logged. Changing of the answer should be logged as two events: answer removed and answer added Make sure students are not able to modify or delete answers of other students and don't see controls for it. Add access restrictions to the choice activity As a teacher make sure that the list of not answered users does not display users who can not access activity Test 2 - logs upgrade On another instance of 3.1 (without changes from this issue) create a course Create a choice activity with multiple responses allowed Complete choice by several students, modify answers, allow teacher to delete some answers View logs for this activity and leave the page open In another window backup the course with user data and logs Restore the backup on upgraded site In the final restore page, where you see the progress bar, open the browser code inspector and locate #executionprogress DOM node, check its contents, there should not be any debugging message View the logs and make sure they are displayed the same Inspect report "Events list" - events "Choice made" and "Choice updated" should be listed as "(no longer used)" Create new event monitor rule - you should not be able to subscribe to these two events but should be able to subscribe to "Choice answer added" and "Choice answer deleted"
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE
    • Pull Master Branch:
      MDL-18592-master

      Description

      I've written code to allow a teacher to assign students who have not responded to a Choice option.

      See discussion: http://moodle.org/mod/forum/discuss.php?d=118914

      Code and screenshots will be posted in the next day or so.

        Gliffy Diagrams

          Attachments

          1. choice_events.png
            choice_events.png
            49 kB
          2. install.txt
            2 kB
          3. selectfor.php
            13 kB
          4. selectfor.v2.0.php
            13 kB
          5. SelectForDemo.pdf
            409 kB

            Issue Links

              Activity

              Hide
              bgray Brian Gray added a comment -

              Most of the new code is in file selectfor.php.

              Minor modifications are required to 4 other files. See install.txt.

              The PDF file includes screenshots with notes on functionality.

              Show
              bgray Brian Gray added a comment - Most of the new code is in file selectfor.php. Minor modifications are required to 4 other files. See install.txt. The PDF file includes screenshots with notes on functionality.
              Hide
              bgray Brian Gray added a comment -

              Revised version of selectfor.php

              Eliminates some bad code – I used a call to get_records_sql() that was not needed and would cause problems on non-standard installations.

              Show
              bgray Brian Gray added a comment - Revised version of selectfor.php Eliminates some bad code – I used a call to get_records_sql() that was not needed and would cause problems on non-standard installations.
              Hide
              bgray Brian Gray added a comment -

              selectfor.v2.0.php is the version of the file for Moodle 2.0. It should be renamed to selectfor.php and then installed with the same instructions as for 1.9.4.

              Show
              bgray Brian Gray added a comment - selectfor.v2.0.php is the version of the file for Moodle 2.0. It should be renamed to selectfor.php and then installed with the same instructions as for 1.9.4.
              Hide
              bgray Brian Gray added a comment -

              Updates to eliminate some PHP warnings and other code cleanup.

              If all users have responded (and therefore there are none to select for) the "Save" and "Randomly assign" buttons do not appear.

              files for 1.9.4 and 2.0 have been updated.

              Show
              bgray Brian Gray added a comment - Updates to eliminate some PHP warnings and other code cleanup. If all users have responded (and therefore there are none to select for) the "Save" and "Randomly assign" buttons do not appear. files for 1.9.4 and 2.0 have been updated.
              Hide
              danmarsden Dan Marsden added a comment -

              Unassigning myself from this as I am not planning to work on this and to allow someone else to pick this up.

              Show
              danmarsden Dan Marsden added a comment - Unassigning myself from this as I am not planning to work on this and to allow someone else to pick this up.
              Hide
              marina Marina Glancy added a comment - - edited

              This is some my weekend activity, this issue is not currently on the HQ roadmap but I thought it could be a nice step forward allowing students to help teacher to allocate them into groups (see MDL-13962)

              Show
              marina Marina Glancy added a comment - - edited This is some my weekend activity, this issue is not currently on the HQ roadmap but I thought it could be a nice step forward allowing students to help teacher to allocate them into groups (see MDL-13962 )
              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: https://github.com/marinaglancy/moodle master (8 errors / 1 warnings) [branch: wip-MDL-18592-master | CI Job ] phplint (0/0) , phpcs (8/0) , js (0/0) , css (0/0) , phpdoc (0/1) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              marina Marina Glancy added a comment -

              Removing from PR queue, I suspect that the list of users who did not answer is not properly filtered
              see MDL-48625 for example

              Show
              marina Marina Glancy added a comment - Removing from PR queue, I suspect that the list of users who did not answer is not properly filtered see MDL-48625 for example
              Hide
              marina Marina Glancy added a comment -

              I added filtering of the non-respondents by access restriction. Sending for peer review

              Show
              marina Marina Glancy added a comment - I added filtering of the non-respondents by access restriction. Sending for peer review
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (8 errors / 1 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (8/0) , js (0/0) , css (0/0) , phpdoc (0/1) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              cameron1729 Cameron Ball added a comment -

              Hey Marina,

              Nice work on this one. Overall I think it looks good. A few minor comments:

              1. I had a merge conflict. It looks like you styles.css is formatted slightly differently from master's.
              2. There is a place in choice_modify_response where you do this:

                $optionsbyuser += [$userid => []];
                $optionsbyuser[$userid][] = $optionid

                Is there any reason it can't just be

                $optionsbyuser += [$userid => [$userid]];

              3. On a related note, there are two separate loops for $userids and $allresponses. Since the user ids are all in $allresponses, couldn't it be done something like:

                mod/choice/lib.php

                $optionsbyanswer = $usersbyanswer = [];
                foreach ($allresponses as $optionid => $responses) {
                    foreach ($responses as $userid => $userresponse) {
                        if ($optionid === 0 && in_array($userid,$userids)) {
                            choice_user_submit_response($newoptionid,$choice,$userid,$course,$cm);
                            continue;
                        }
                        if ($optionid > 0) {
                            $optionsbyuser += [$userid => [$optionid]];
                            $usersbyanswer[$userresponse->answerid] = $userid;
                        }
                    }
                }

                I tried the above and it passes PHPUnit and behat; but I haven't thought about it too much.

              4. I don't know how hard it would be... But it would be nice to be able to shift-click the checkboxes. At the moment, if I want to select an entire column I have to do it one by one. It would be cool to be able to click the top one, then shift-click the bottom one to get them all.
              5. It looks like a few of CiBoT's complaints are legitimate (the one about NULL, and the one about having a space after the comma)

              I reran the unit tests because of the fail; and everything seems to work.

              Overall I think this patch is good. I don't think my points require too much consideration (except maybe the merge conflict one). Feel free to push this for integration when you're ready. Cheers!

              Show
              cameron1729 Cameron Ball added a comment - Hey Marina, Nice work on this one. Overall I think it looks good. A few minor comments: I had a merge conflict. It looks like you styles.css is formatted slightly differently from master's. There is a place in choice_modify_response where you do this: $optionsbyuser += [ $userid => []]; $optionsbyuser [ $userid ][] = $optionid Is there any reason it can't just be $optionsbyuser += [ $userid => [ $userid ]]; On a related note, there are two separate loops for $userids and $allresponses . Since the user ids are all in $allresponses , couldn't it be done something like: mod/choice/lib.php $optionsbyanswer = $usersbyanswer = []; foreach ( $allresponses as $optionid => $responses ) { foreach ( $responses as $userid => $userresponse ) { if ( $optionid === 0 && in_array( $userid , $userids )) { choice_user_submit_response( $newoptionid , $choice , $userid , $course , $cm ); continue ; } if ( $optionid > 0) { $optionsbyuser += [ $userid => [ $optionid ]]; $usersbyanswer [ $userresponse ->answerid] = $userid ; } } } I tried the above and it passes PHPUnit and behat; but I haven't thought about it too much. I don't know how hard it would be... But it would be nice to be able to shift-click the checkboxes. At the moment, if I want to select an entire column I have to do it one by one. It would be cool to be able to click the top one, then shift-click the bottom one to get them all. It looks like a few of CiBoT's complaints are legitimate (the one about NULL, and the one about having a space after the comma) I reran the unit tests because of the fail; and everything seems to work. Overall I think this patch is good. I don't think my points require too much consideration (except maybe the merge conflict one). Feel free to push this for integration when you're ready. Cheers!
              Hide
              marina Marina Glancy added a comment -

              Thanks for the review Cameron,
              2. I assume you meant

              $optionsbyuser += [$userid => [$optionid]];
              

              but it is still not an identical substitute - it will not work in case of multiple choice setting.
              3. same thing - did you try multiple choice?
              4. yup, I thought about it but ran out of time. I'm sure somebody can add it later

              Show
              marina Marina Glancy added a comment - Thanks for the review Cameron, 2. I assume you meant $optionsbyuser += [$userid => [$optionid]]; but it is still not an identical substitute - it will not work in case of multiple choice setting. 3. same thing - did you try multiple choice? 4. yup, I thought about it but ran out of time. I'm sure somebody can add it later
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (6 errors / 0 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (6/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (6 errors / 0 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (6/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              cameron1729 Cameron Ball added a comment -

              Hey Marina,

              For 2, yeah I did mean that. Looking at it again, if I understand correctly, this should work:

              $optionsbyuser[$userid][] = $optionid;
              

              It looks like you're using the array union operator to initialise a new empty array (if there isn't already an array at that index), so you can append to it on the next line. You don't need to do that, PHP is really lax about initialising variables: https://3v4l.org/XboDX

              Show
              cameron1729 Cameron Ball added a comment - Hey Marina, For 2, yeah I did mean that. Looking at it again, if I understand correctly, this should work: $optionsbyuser [ $userid ][] = $optionid ; It looks like you're using the array union operator to initialise a new empty array (if there isn't already an array at that index), so you can append to it on the next line. You don't need to do that, PHP is really lax about initialising variables: https://3v4l.org/XboDX
              Hide
              dmonllao David Monllaó added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              dmonllao David Monllaó added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (6 errors / 0 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (6/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              dmonllao David Monllaó added a comment -

              Thanks for working on this Marina. I've reviewed the patch, a few different fixes in 1 issue but it is ok, I've also tested restore looking for debugging messages and all good (validate_data seems to be only called when creating the event)

              For what I've been able to test I think that I've found a problem with this UI, how can I select 2 options for 1 user if multiple options is enabled? If I select an option that is already selected for that user nothing changes, if I select another option the previosly selected options are unselected, I don't see any other way that changing the UI, the best alternative I can think of is a button for delete and a select multioption (I don't think autosubmit is applicable) to update choices. Feel free to propose other UIs.

              Show
              dmonllao David Monllaó added a comment - Thanks for working on this Marina. I've reviewed the patch, a few different fixes in 1 issue but it is ok, I've also tested restore looking for debugging messages and all good (validate_data seems to be only called when creating the event) For what I've been able to test I think that I've found a problem with this UI, how can I select 2 options for 1 user if multiple options is enabled? If I select an option that is already selected for that user nothing changes, if I select another option the previosly selected options are unselected, I don't see any other way that changing the UI, the best alternative I can think of is a button for delete and a select multioption (I don't think autosubmit is applicable) to update choices. Feel free to propose other UIs.
              Hide
              dmonllao David Monllaó added a comment -

              I'm reopening this so we have more time to discuss about the UI. Thanks.

              Show
              dmonllao David Monllaó added a comment - I'm reopening this so we have more time to discuss about the UI. Thanks.
              Hide
              cibot CiBoT added a comment -

              Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

              Show
              cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
              Hide
              marina Marina Glancy added a comment -

              Hello David,
              sorry slowly getting from the list of my tracker emails after the holidays.
              When multiple choice is enabled teacher can add as many options for each user as he wants. The existing one is not being unselected. I think you did not test it correctly

              Show
              marina Marina Glancy added a comment - Hello David, sorry slowly getting from the list of my tracker emails after the holidays. When multiple choice is enabled teacher can add as many options for each user as he wants. The existing one is not being unselected. I think you did not test it correctly
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (6 errors / 0 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (6/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              • master [branch: MDL-18592-master | CI Job]
                • Error: The MDL-18592-master branch at git://github.com/marinaglancy/moodle.git does not apply clean to origin/master

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master [branch: MDL-18592-master | CI Job ] Error: The MDL-18592 -master branch at git://github.com/marinaglancy/moodle.git does not apply clean to origin/master More information about this report
              Hide
              marina Marina Glancy added a comment -

              rebased to fix conflict with last week's integration

              Show
              marina Marina Glancy added a comment - rebased to fix conflict with last week's integration
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (7 errors / 0 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (6/0) , js (0/0) , css (1/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Hi Marina,

              Can you confirm, with the testing instructions you state

              Create a choice activity with multiple responses allowed

              Can you confirm which of the following you mean by this:

              1. Allow more than one choice to be selected
              2. Limit the number of responses allowed Help with Limit the number of responses allowed
              Show
              dobedobedoh Andrew Nicols added a comment - Hi Marina, Can you confirm, with the testing instructions you state Create a choice activity with multiple responses allowed Can you confirm which of the following you mean by this: Allow more than one choice to be selected Limit the number of responses allowed Help with Limit the number of responses allowed
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Hi Marina,

              This change looks good and, aside from the difficulty in selecting multiple users already mentioned, provides some nice functionality.

              I do have a couple of concerns about the deprecated events, and I wonder whether this perhaps highlights a flaw in the Events API.

              You have deprecated 2 events, and created 1 new event:

              1. answer_created - new event
              2. answer_submitted - deprecated
              3. answer_updated - deprecated

              I notice that the created and submitted events share the same language string.
              This becomes a problem when using the Event Monitor and adding a rule:

              Also, I notice that the deprecation notice is in a code comment but is not displayed anywhere else.

              I wonder whether this highlights the need for a new part of the API to deprecate these events - e.g. a new function which indicates whether the event has been deprecated which can then alter the UI as required.

              I do not think that modifying the existing language strings to indicate the deprecation is sufficient as translators will need to modify their strings before the UI will be updated and this could take some time.

              I've also asked Rajesh Taneja to take a look at the behat tests.
              Clicking on a checkbox is not a valid behaviour as it is a form element, and we should be able to remove the @javascript tag from these tests too.

              Otherwise I believe that this change looks good.

              Looking forward to your comments,

              Andrew

              Show
              dobedobedoh Andrew Nicols added a comment - Hi Marina, This change looks good and, aside from the difficulty in selecting multiple users already mentioned, provides some nice functionality. I do have a couple of concerns about the deprecated events, and I wonder whether this perhaps highlights a flaw in the Events API. You have deprecated 2 events, and created 1 new event: answer_created - new event answer_submitted - deprecated answer_updated - deprecated I notice that the created and submitted events share the same language string. This becomes a problem when using the Event Monitor and adding a rule: Also, I notice that the deprecation notice is in a code comment but is not displayed anywhere else. I wonder whether this highlights the need for a new part of the API to deprecate these events - e.g. a new function which indicates whether the event has been deprecated which can then alter the UI as required. I do not think that modifying the existing language strings to indicate the deprecation is sufficient as translators will need to modify their strings before the UI will be updated and this could take some time. I've also asked Rajesh Taneja to take a look at the behat tests. Clicking on a checkbox is not a valid behaviour as it is a form element, and we should be able to remove the @javascript tag from these tests too. Otherwise I believe that this change looks good. Looking forward to your comments, Andrew
              Hide
              marina Marina Glancy added a comment -

              hi Andrew, I meant "Allow more than one choice to be selected"

              good point about event monitor - the deprecated events should never be monitored, they can no longer be triggered. I wonder how can we do it - maybe hardcode in the event monitor?
              Deprecation notice appears when validate_data() is called and it is only called during triggering event and not called during restore.

              I will add a new string

              Show
              marina Marina Glancy added a comment - hi Andrew, I meant "Allow more than one choice to be selected" good point about event monitor - the deprecated events should never be monitored, they can no longer be triggered. I wonder how can we do it - maybe hardcode in the event monitor? Deprecation notice appears when validate_data() is called and it is only called during triggering event and not called during restore. I will add a new string
              Hide
              marina Marina Glancy added a comment -

              blocking this [forever] with MDL-46214

              Show
              marina Marina Glancy added a comment - blocking this [forever] with MDL-46214
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-18592 using repository: git://github.com/marinaglancy/moodle.git master (7 errors / 0 warnings) [branch: MDL-18592-master | CI Job ] phplint (0/0) , phpcs (6/0) , js (0/0) , css (1/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , grunt (0/0) , shifter (0/0) , travis (0/0) , More information about this report
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Stopping review of this issue while we wait for the blocker.

              Show
              dobedobedoh Andrew Nicols added a comment - Stopping review of this issue while we wait for the blocker.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Marina, integrated to master

              Show
              poltawski Dan Poltawski added a comment - Thanks Marina, integrated to master
              Hide
              marina Marina Glancy added a comment - - edited

              oops, this was not added after MDL-46214 was integrated:
              https://github.com/marinaglancy/moodle/compare/x-int-master...wip-MDL-18592-fix
              Can somebody pull it in please?

              git pull https://github.com/marinaglancy/moodle/ wip-MDL-18592-fix
              

              Show
              marina Marina Glancy added a comment - - edited oops, this was not added after MDL-46214 was integrated: https://github.com/marinaglancy/moodle/compare/x-int-master...wip-MDL-18592-fix Can somebody pull it in please? git pull https://github.com/marinaglancy/moodle/ wip-MDL-18592-fix
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Thanks Marina,

              I've pulled those changes now.

              Show
              dobedobedoh Andrew Nicols added a comment - Thanks Marina, I've pulled those changes now.
              Hide
              ryanwyllie Ryan Wyllie added a comment -

              Hey Marina,

              Everything looks goof on the tested except for step 8 of test 2. It doesn't look like all of the logs were included as part of the backup/restore process. There are a bunch of logs from the admin that are missing in the restored course.

              Show
              ryanwyllie Ryan Wyllie added a comment - Hey Marina, Everything looks goof on the tested except for step 8 of test 2. It doesn't look like all of the logs were included as part of the backup/restore process. There are a bunch of logs from the admin that are missing in the restored course.
              Hide
              ryanwyllie Ryan Wyllie added a comment -

              Just spoke with Marina. The problem was with me using the admin user which won't have logs restored.

              Please put this back to testing for me to continue.

              Show
              ryanwyllie Ryan Wyllie added a comment - Just spoke with Marina. The problem was with me using the admin user which won't have logs restored. Please put this back to testing for me to continue.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks Ryan and Marina,

              Sending this back for testing...

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks Ryan and Marina, Sending this back for testing...
              Hide
              ryanwyllie Ryan Wyllie added a comment -

              Thanks Marina, tested with an actual teacher (rather than admin) and logs are all good.

              Testing passed.

              Show
              ryanwyllie Ryan Wyllie added a comment - Thanks Marina, tested with an actual teacher (rather than admin) and logs are all good. Testing passed.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

              Show
              poltawski Dan Poltawski added a comment - Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

                People

                • Votes:
                  22 Vote for this issue
                  Watchers:
                  14 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Nov/16