Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-14584 META: NTLM problems
  3. MDL-18596

login https is not working when NTLM is enabled, but authentication fails

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.9.6, 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      I have loginhttps enabled and NTLM enabled for IPs within the organisation, but some machines which are not part of the domain, or use firefox go to the offcampus login page. This page is not encrypted with https, although it should be.

        Gliffy Diagrams

        1. ntlm-https-fast-path-ie-19.diff
          0.5 kB
          Iñaki Arenaza
        2. ntlm-https-fast-path-ie-19-v2.diff
          0.5 kB
          Iñaki Arenaza

          Issue Links

            Activity

            Hide
            iarenaza Iñaki Arenaza added a comment -

            Hi Matt,

            I thinks this is fixed as part of the MDL-14078 fix I commited on 2009.02.14 for 1.9 and HEAD. Is your 1.9.4 version older or newer than that date?

            If the last two lines (except the closing '}') from .../auth/ldap/ntlmsso_finish.php are:

            redirect($CFG->httpswwwroot . '/login/index.php?authldap_skipntlmsso=1',
            get_string('ntlmsso_failed','auth'), 3);

            and you still have this issue, I'll try to debug and fix it with your help

            Saludos. Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - Hi Matt, I thinks this is fixed as part of the MDL-14078 fix I commited on 2009.02.14 for 1.9 and HEAD. Is your 1.9.4 version older or newer than that date? If the last two lines (except the closing '}') from .../auth/ldap/ntlmsso_finish.php are: redirect($CFG->httpswwwroot . '/login/index.php?authldap_skipntlmsso=1', get_string('ntlmsso_failed','auth'), 3); and you still have this issue, I'll try to debug and fix it with your help Saludos. Iñaki.
            Hide
            iarenaza Iñaki Arenaza added a comment -

            Matt,

            I've been testing this a bit, and it seems there's actually a bug when you have the 'MS IE Fast Path' option enabled (otherwise it works as expected with the 1.9.4 current as of today).

            Could you please try the attached patch?

            Saludos. Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - Matt, I've been testing this a bit, and it seems there's actually a bug when you have the 'MS IE Fast Path' option enabled (otherwise it works as expected with the 1.9.4 current as of today). Could you please try the attached patch? Saludos. Iñaki.
            Hide
            iarenaza Iñaki Arenaza added a comment -

            The previous patch seems to be bogus and doesn't apply cleanly (I just don't know why, as I created it with git). Anyway, please use this one better

            Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - The previous patch seems to be bogus and doesn't apply cleanly (I just don't know why, as I created it with git). Anyway, please use this one better Iñaki.
            Hide
            skodak Petr Skoda added a comment -

            patch looks ok, reassigning, please commit after some more testing

            Show
            skodak Petr Skoda added a comment - patch looks ok, reassigning, please commit after some more testing
            Hide
            iarenaza Iñaki Arenaza added a comment -

            Matt,

            did you try my last patch? If so, did it fix your issue?

            Saludos. Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - Matt, did you try my last patch? If so, did it fix your issue? Saludos. Iñaki.
            Hide
            iarenaza Iñaki Arenaza added a comment -

            Fixed in CVS for both 1.9 and HEAD.

            Thanks a lot Matt for the report!

            Saludos.
            Iñaki.

            Show
            iarenaza Iñaki Arenaza added a comment - Fixed in CVS for both 1.9 and HEAD. Thanks a lot Matt for the report! Saludos. Iñaki.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  21/Oct/09