Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Won't Fix
-
Affects Version/s: 1.9.4
-
Fix Version/s: None
-
Component/s: Global search
-
Labels:None
-
Affected Branches:MOODLE_19_STABLE
Description
Please see item 11. at http://docs.moodle.org/en/Development:Coding#Database_structures
Do not use 'AS' for table aliases in SQL. That is
SELECT x + y AS name ... is correct.
SELECT * FROM
{table} AS alias ... is WRONG. it should be SELECT * FROM {table}alias ...
if you don't get this right, then it breaks on at least one of our supported databases. You have this wrong throughout the serach code.
Also, in HEAD, you are using the old get_record_sql, get_field, ... functions, which do not work any more.