Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18669

get_string needs to be refactored

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0
    • 2.0
    • Libraries
    • None
    • MOODLE_20_STABLE
    • MOODLE_20_STABLE

    Description

      It looks like far too much copy-paste has gone on over the years. I am going to have a go at fixing it, and rolling in the fixes for MDL-17763, MDL-16181 and MDL-12434 at the same time.

      Attachments

        1. get_string.patch.txt
          291 kB
        2. get_string.patch.txt
          256 kB
        3. get_string.patch.txt
          28 kB
        4. get_string.patch.txt
          23 kB
        5. get_string timings.ods
          20 kB

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              timhunt Tim Hunt
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                24/Nov/10