Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7, 1.8, 1.9
    • Fix Version/s: 1.8.13, 1.9.9, 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Environment:
      Any system using CAS authentication and syncing.
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      31448

      Description

      In reviewing the log output generated from the cas_ldap_sync_users.php I noticed that the revive section had nothing but bracketed text. Looking at auth.php I discovered the following lines of code had a typo in them

      if (update_record('user', $updateuser))

      { echo "\t"; print_string('auth_dbreviveser', 'auth', array($user->username, $user->id)); echo "\n"; }

      else

      { echo "\t"; print_string('auth_dbreviveusererror', 'auth', $user->username); echo "\n"; }

      The auth_dbreviveser and auth_dbreviveusererror should actually be auth_dbreviveduser and auth_dbrevivedusererror

        Activity

        Hide
        Jerome Charaoui added a comment -

        These typos are also present in the auth/ldap module (lines 683 and 685) as well as the auth/db module (line 365), in CVS HEAD.

        Show
        Jerome Charaoui added a comment - These typos are also present in the auth/ldap module (lines 683 and 685) as well as the auth/db module (line 365), in CVS HEAD.
        Hide
        Iñaki Arenaza added a comment -

        The same typo was present in auth/cas, auth/db and auth/ldap.

        This should be fixed in CVS for both 1.8.x, 1.9.x and HEAD.

        Thanks a lot to Scott Karren and Jêrome Charaoui for the bug report and comments

        Saludos,
        Iñaki.

        Show
        Iñaki Arenaza added a comment - The same typo was present in auth/cas, auth/db and auth/ldap. This should be fixed in CVS for both 1.8.x, 1.9.x and HEAD. Thanks a lot to Scott Karren and Jêrome Charaoui for the bug report and comments Saludos, Iñaki.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: