Moodle
  1. Moodle
  2. MDL-18719

Password expired would you like to change it yes button redirects to login screen

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.1
    • Fix Version/s: 1.8.10, 1.9.6, 2.0
    • Component/s: Authentication
    • Labels:
      None
    • Environment:
      LAMP server, authenticating through remote LDAP Novell eDirectory server
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      31439

      Description

      When a user's password expires they are presented with a warning and a choice to change their password. However the 'yes' button doesn't redirect them to the change password page but to the login page. This is the code for the warning/buttons:

      <div id="content" class=" clearfix"><div id="notice" class="generalbox box"><p>Your password is expired. Do you want change your password now?</p><div class="buttons"><div class="singlebutton"><form action="" method="post"><div><input type="submit" value="Yes" /></div></form></div><div class="singlebutton"><form action="http://moodle.tauntons.ac.uk/" method="post"><div><input type="submit" value="No" /></div></form></div></div></div></div><div id="footer"><hr /><p class="helplink"></p><div class="logininfo">You are logged in as <a href="http://moodle.tauntons.ac.uk/user/view.php?id=2928&course=1">test user</a> (<a href="http://moodle.tauntons.ac.uk/login/logout.php?sesskey=csASm4y1YQ">Logout</a>)</div><div class="homelink"><a href="http://moodle.tauntons.ac.uk/">Home</a></div></div>

      The problem seems to be that there is no action for the form in which the yes button sits.

      I've tried changing the configuration of ldap authentication to use a different change password url, setting the url the url of the normal change password page, but this just results in ie sitting loading but not getting anywhere while konqueror complains about a cyclic link.

      The change password page works perfectly through the profile button.

        Activity

        Hide
        Iñaki Arenaza added a comment -

        Hi Mike,

        can you try the attached patch?

        Saludos. Iñaki.

        Show
        Iñaki Arenaza added a comment - Hi Mike, can you try the attached patch? Saludos. Iñaki.
        Hide
        Mike Worth added a comment -

        Yes, that's done the trick.

        Thanks a lot,
        Mike

        Show
        Mike Worth added a comment - Yes, that's done the trick. Thanks a lot, Mike
        Hide
        Iñaki Arenaza added a comment -

        Fixed in CVS for versions 1.8, 1.9 and HEAD.

        Mike, thanks a lot for reporting the bug and testing the fix!

        Saludos.
        Iñaki.

        Show
        Iñaki Arenaza added a comment - Fixed in CVS for versions 1.8, 1.9 and HEAD. Mike, thanks a lot for reporting the bug and testing the fix! Saludos. Iñaki.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: