Details
Minor
Description
The files /portfolio/*.php do not have require_login()
Those scripts are using $USER and $SESSION, adding require logins and adding forgotten kill switch into portfolio/file.php
Please review and test 
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Hey Petr, good catch. I'll add docs too.
What do you want me to review? There's no patch on this bug and nothing in the version control tab?
I don't understand your comment about optional_param - that isn't deprecated, what's the problem?
ooops, I must have used some other bug number 
see cvs
looks fine.I'll look at the docs as time allows.
Petr -still waiting on hearing back on the problem with optional_param.
from http://docs.moodle.org/en/Development:Coding:
8. Wherever possible group all your required_param(), optional_param() and other variables initialisation at the beginning of each file to make them easy to find.
fair enough.
I suppose in this case could be separate groups at the start of each case/if
I think I was probably trying to avoid unnecessary variable assignment, but it really doesn't matter. I will just put it all at the top.
added docs and moved all optional_param and required_param to the top.
silly question, why is add.php using optional_param() all over the place?
It would be also nice if each script contained a short description describing what it does, especially when is uses something from session created by other scripts.