Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-18770

Non-graded Assignment and Quizzes appear in the gradebook and have Max Grade assigned

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.9, 1.9.1, 1.9.2, 1.9.3, 1.9.4, 2.3.3, 2.4
    • Fix Version/s: 2.7
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      1. Create new assign with grade set to "No grade" and no feedback types selected
      2. Go to course grades and select "Simple view"
      3. Make suer Assignment is not listed. Check grader report and assignment should not be visible.
      4. Edit assignment and enable feedback which is set for feedback_plugin_for_gradebook (default is "Feedback comments")
      5. Go to gradebook simple view and make sure assignment is visible and max grade is '-'
      6. Edit assignment again, set grade to 99 and uncheck all feedback types
      7. Go to gradebook simple view and make sure assignment is visible and max grade is '99'
      8. Edit assignment again, set grade to 99 and check feedback comments and feedback filetypes
      9. Go to gradebook simple view and make sure assignment is visible and max grade is '99'
      10. Edit assignment again and set grade to "No grade" and uncheck "Feedback comments" (leave Feedback filetypes checked)
      11. Go to gradereport simple view and make suer Assignment is not listed.

      Test 2:

      1. Reset course and make sure assignment visibility in gradebook is not changed.
      2. Backup and restore course and make sure assignment visibility in gradebook is not changed.
      3. Duplicate assignment and make sure assignment visibility in gradebook is not changed.

      Test 3:

      1. Run phpunit
        • mod/assign/tests/locallib_test.php
        • grade/tests/edittreelib_test.php
      Show
      Create new assign with grade set to "No grade" and no feedback types selected Go to course grades and select "Simple view" Make suer Assignment is not listed. Check grader report and assignment should not be visible. Edit assignment and enable feedback which is set for feedback_plugin_for_gradebook (default is "Feedback comments") Go to gradebook simple view and make sure assignment is visible and max grade is '-' Edit assignment again, set grade to 99 and uncheck all feedback types Go to gradebook simple view and make sure assignment is visible and max grade is '99' Edit assignment again, set grade to 99 and check feedback comments and feedback filetypes Go to gradebook simple view and make sure assignment is visible and max grade is '99' Edit assignment again and set grade to "No grade" and uncheck "Feedback comments" (leave Feedback filetypes checked) Go to gradereport simple view and make suer Assignment is not listed. Test 2: Reset course and make sure assignment visibility in gradebook is not changed. Backup and restore course and make sure assignment visibility in gradebook is not changed. Duplicate assignment and make sure assignment visibility in gradebook is not changed. Test 3: Run phpunit mod/assign/tests/locallib_test.php grade/tests/edittreelib_test.php
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      wip-mdl-18770
    • Story Points:
      13
    • Sprint:
      BACKEND Sprint 8

      Description

      Non-graded Assignment and Quizzes are getting displayed in the gradebook, and they look like being included into aggregation in the Cat&Items interface, since they have Max Grade value set to 100.
      Other activities behave definitely. E.g. If Forum is not graded, it does not appear in the gradebook as a column. Which for me is an expected behavior.

      1. Add an Assignment. Set it to No Grade. Column will still appear in the gradebook. Now go to the Cat&Items interface. It will display Max Grade for that column to be 100 points. (Though it will not be actually included into the calculation)
      2. Add an Assignment. Set it to be graded on a scale (scales are NOT included in aggregation for us). Maximum Grade in the Cat&Items interface will display some number (e.g. 3, if there are 3 items in a scale). It is confusing, since one would now expect that 3 to be calculated toward course/category total.
      3. Add a quiz, add some questions, and make the quiz to be worth 0 points. Maximum Grade in the Cat&Items interface will still be 10 points (or 100). Interestingly enough, I can manually delete a gradebook column for this kind of quiz. (But, once I delete a column, there is no way for me add it back, even though I will make the quiz gradable)

      I think MDL-14017 is related to this.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              elenaivanova Elena Ivanova
              Peer reviewer:
              Adrian Greeve
              Integrator:
              Sam Hemelryk
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              39 Vote for this issue
              Watchers:
              33 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14