Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19038

admin_setting_users_with_capability sometimes load all uusers in admin/settings/courses.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.9.5
    • Component/s: Administration
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Reported by Sam in Moodle HQ chat:

      with moodle 1.9.4 we see a critical performance problem on the root /index.php (or anywhere that draws the site admin block). We've tracked this down to a usage in courses.php of admin_setting_users_with_capability which ends up doing a pretty horrible get_users_with_capability that returns all 500,000 users. This line of code is still there in current MOODLE_19, but I wonder if it's been fixed in any way - does anyone know?

      (unfortunately our moodle 1.9 test installs don't have large user numbers)

      (ie basically, is this our system being slow, or is there something wrong with our settings for the capability in question, moodle/site:approvecourse)

        Attachments

          Activity

            People

            • Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/09