Moodle
  1. Moodle
  2. MDL-19060

the search for test files to run could be a bit more discriminating.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.5, 2.0
    • Fix Version/s: 1.9.8
    • Component/s: Unit tests
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Rank:
      31731

      Description

      Things like ....

      Unexpected PHP error [file_get_contents(/var/www/moodle/eventmanager/local/simpletest/.testlocal.php.swp)
      And searching CVS or .git/objects

      Could be avoided by using a list of excludes or similar.

        Activity

        Hide
        Andrew Davis added a comment -

        Ive made changes to filter out cvs and .git directories however they are uncommitted. I'm waiting for 1.9.7 to be out before committing them.

        I haven't been able to determine if the regular expression involved has been modified since this bug was submitted but a file with a name like .testlocal.php.swp won't be mistaken for a test file with the code as it currently stands.

        Show
        Andrew Davis added a comment - Ive made changes to filter out cvs and .git directories however they are uncommitted. I'm waiting for 1.9.7 to be out before committing them. I haven't been able to determine if the regular expression involved has been modified since this bug was submitted but a file with a name like .testlocal.php.swp won't be mistaken for a test file with the code as it currently stands.
        Hide
        Andrew Davis added a comment -

        committed.

        Show
        Andrew Davis added a comment - committed.
        Hide
        Tim Hunt added a comment -

        Andrew, there was already code there to skip CVS directories.

        If it was not working, and your new code does, then you should have removed the old code.

        If the old code did work, you should probably have done the code for .git folders in the same way.

        Please can you sort it out.

        Show
        Tim Hunt added a comment - Andrew, there was already code there to skip CVS directories. If it was not working, and your new code does, then you should have removed the old code. If the old code did work, you should probably have done the code for .git folders in the same way. Please can you sort it out.
        Hide
        Andrew Davis added a comment -

        wow, thats embarrassing. Im not sure how I didnt notice that existing check. I've switched the git check to work the same way as the existing cvs check and removed the redundant cvs check.

        Show
        Andrew Davis added a comment - wow, thats embarrassing. Im not sure how I didnt notice that existing check. I've switched the git check to work the same way as the existing cvs check and removed the redundant cvs check.
        Hide
        Dongsheng Cai added a comment -

        Thanks for fixing it Andrew, closing

        Show
        Dongsheng Cai added a comment - Thanks for fixing it Andrew, closing

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: