Moodle
  1. Moodle
  2. MDL-19071

Look for working unicode regex in environmental checks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.4, 2.3
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1/ go to Admin / Server / Environment and verify that there is a pcreunicode test is present and that is is succeeding (assuming you don't have a buggy install yourself)
      2/ Try a fresh install and verify the same
      3/ With a buggy install (e.g. CentOS 5.5) try an install and test that it is reporting failure with a warning message, the install is not prevented

      Show
      1/ go to Admin / Server / Environment and verify that there is a pcreunicode test is present and that is is succeeding (assuming you don't have a buggy install yourself) 2/ Try a fresh install and verify the same 3/ With a buggy install (e.g. CentOS 5.5) try an install and test that it is reporting failure with a warning message, the install is not prevented
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w18_MDL-19071_m23_unicode
    • Rank:
      395

      Description

      We need full regex unicode support in several places, it should be imo made required and tested in environment check.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Tip: look for $unicoderegexp in backup/backulib.php for a way to check if unicode is fullly supported by regexp functions.

          Show
          Eloy Lafuente (stronk7) added a comment - Tip: look for $unicoderegexp in backup/backulib.php for a way to check if unicode is fullly supported by regexp functions.
          Hide
          Petr Škoda added a comment -

          ok, so for now I will make it env warning and later we can decide to make it error in 2.4...

          Show
          Petr Škoda added a comment - ok, so for now I will make it env warning and later we can decide to make it error in 2.4...
          Hide
          Petr Škoda added a comment -

          From Eloy: tip: Perhaps the check can be isolated in common function so we can replace 3-4 current uses of custom checks by it.

          grep -r '@preg_match.*pL' *

          Show
          Petr Škoda added a comment - From Eloy: tip: Perhaps the check can be isolated in common function so we can replace 3-4 current uses of custom checks by it. grep -r '@preg_match.*pL' *
          Hide
          Petr Škoda added a comment -

          Sam says: bug report says CentOS 5.5

          Show
          Petr Škoda added a comment - Sam says: bug report says CentOS 5.5
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Thanks Petr that has been integrated now.

          We need some docs on this check at
          http://docs.moodle.org/23/en/admin/environment/pcreunicode

          Helen: Not sure the best way of us managing these additions to docs (we could actually document it in place there since its still relevant to 2.2)

          Show
          Dan Poltawski added a comment - Thanks Petr that has been integrated now. We need some docs on this check at http://docs.moodle.org/23/en/admin/environment/pcreunicode Helen: Not sure the best way of us managing these additions to docs (we could actually document it in place there since its still relevant to 2.2)
          Hide
          Helen Foster added a comment -

          If it's also relevant to 2.2, please could someone write a few notes about it here http://docs.moodle.org/22/en/admin/environment/pcreunicode

          Show
          Helen Foster added a comment - If it's also relevant to 2.2, please could someone write a few notes about it here http://docs.moodle.org/22/en/admin/environment/pcreunicode
          Hide
          Rajesh Taneja added a comment -

          Thanks Petr,

          I can see pcreunicode warning, on fresh install and while upgrading on buggy system.

          Passing the test

          Show
          Rajesh Taneja added a comment - Thanks Petr, I can see pcreunicode warning, on fresh install and while upgrading on buggy system. Passing the test
          Hide
          Eloy Lafuente (stronk7) added a comment -
          UPDATE tracker_issues
             SET status = 'Closed',
                comment = 'Thanks!'
          WHEN participants = 'Did a gorgeous work'
          

          This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          Show
          Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).
          Hide
          Helen Foster added a comment -

          The pcreunicode environment check now has a documentation page:
          http://docs.moodle.org/en/admin/environment/pcreunicode

          Hoping someone can add info to the page or add a comment here explaining what needs adding so I can do it!

          Show
          Helen Foster added a comment - The pcreunicode environment check now has a documentation page: http://docs.moodle.org/en/admin/environment/pcreunicode Hoping someone can add info to the page or add a comment here explaining what needs adding so I can do it!
          Hide
          Mary Cooch added a comment -

          Jut wondering if anyone has time to add to the documentation page Helen created here: http://docs.moodle.org/25/en/admin/environment/pcreunicode

          Show
          Mary Cooch added a comment - Jut wondering if anyone has time to add to the documentation page Helen created here: http://docs.moodle.org/25/en/admin/environment/pcreunicode

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: