Moodle
  1. Moodle
  2. MDL-19071

Look for working unicode regex in environmental checks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.9.4, 2.3
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1/ go to Admin / Server / Environment and verify that there is a pcreunicode test is present and that is is succeeding (assuming you don't have a buggy install yourself)
      2/ Try a fresh install and verify the same
      3/ With a buggy install (e.g. CentOS 5.5) try an install and test that it is reporting failure with a warning message, the install is not prevented

      Show
      1/ go to Admin / Server / Environment and verify that there is a pcreunicode test is present and that is is succeeding (assuming you don't have a buggy install yourself) 2/ Try a fresh install and verify the same 3/ With a buggy install (e.g. CentOS 5.5) try an install and test that it is reporting failure with a warning message, the install is not prevented
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w18_MDL-19071_m23_unicode
    • Rank:
      395

      Description

      We need full regex unicode support in several places, it should be imo made required and tested in environment check.

        Issue Links

          Activity

          Petr Škoda created issue -
          Petr Škoda made changes -
          Field Original Value New Value
          Link This issue has been marked as being related by MDL-18799 [ MDL-18799 ]
          Petr Škoda made changes -
          Link This issue has been marked as being related by MDL-2795 [ MDL-2795 ]
          Eloy Lafuente (stronk7) made changes -
          Link This issue blocks MDL-15057 [ MDL-15057 ]
          Eloy Lafuente (stronk7) made changes -
          Link This issue blocks MDL-15057 [ MDL-15057 ]
          Eloy Lafuente (stronk7) made changes -
          Link This issue will help resolve MDL-15057 [ MDL-15057 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Tip: look for $unicoderegexp in backup/backulib.php for a way to check if unicode is fullly supported by regexp functions.

          Show
          Eloy Lafuente (stronk7) added a comment - Tip: look for $unicoderegexp in backup/backulib.php for a way to check if unicode is fullly supported by regexp functions.
          Martin Dougiamas made changes -
          Fix Version/s 2.0.1 [ 10420 ]
          Fix Version/s 2.0 [ 10122 ]
          Martin Dougiamas made changes -
          Workflow jira [ 31791 ] MDL Workflow [ 44864 ]
          Martin Dougiamas made changes -
          Fix Version/s 2.0.2 [ 10421 ]
          Fix Version/s 2.0.1 [ 10420 ]
          Martin Dougiamas made changes -
          Fix Version/s 2.0.3 [ 10537 ]
          Fix Version/s 2.0.2 [ 10421 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 44864 ] MDL Full Workflow [ 73222 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.0.4 [ 10652 ]
          Fix Version/s 2.0.3 [ 10537 ]
          Martin Dougiamas made changes -
          Fix Version/s 2.0.5 [ 10950 ]
          Fix Version/s 2.0.4 [ 10652 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.0.6 [ 11250 ]
          Fix Version/s 2.0.5 [ 10950 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.0.7 [ 11451 ]
          Fix Version/s 2.0.6 [ 11250 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.0.8 [ 11554 ]
          Fix Version/s 2.0.7 [ 11451 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.0.9 [ 12051 ]
          Fix Version/s 2.0.8 [ 11554 ]
          Sam Marshall made changes -
          Link This issue is duplicated by MDL-32629 [ MDL-32629 ]
          Petr Škoda made changes -
          Assignee Eloy Lafuente (stronk7) [ stronk7 ] Petr Škoda (skodak) [ skodak ]
          Eloy Lafuente (stronk7) made changes -
          Summary Check for wokring unicode regex Look for working unicode regex in environmental cheks
          Priority Major [ 3 ] Critical [ 2 ]
          Assignee Petr Škoda (skodak) [ skodak ] moodle.com [ moodle.com ]
          Petr Škoda made changes -
          Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
          Petr Škoda made changes -
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s 2.0.9 [ 12051 ]
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Hide
          Petr Škoda added a comment -

          ok, so for now I will make it env warning and later we can decide to make it error in 2.4...

          Show
          Petr Škoda added a comment - ok, so for now I will make it env warning and later we can decide to make it error in 2.4...
          Hide
          Petr Škoda added a comment -

          From Eloy: tip: Perhaps the check can be isolated in common function so we can replace 3-4 current uses of custom checks by it.

          grep -r '@preg_match.*pL' *

          Show
          Petr Škoda added a comment - From Eloy: tip: Perhaps the check can be isolated in common function so we can replace 3-4 current uses of custom checks by it. grep -r '@preg_match.*pL' *
          Hide
          Petr Škoda added a comment -

          Sam says: bug report says CentOS 5.5

          Show
          Petr Škoda added a comment - Sam says: bug report says CentOS 5.5
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/95ef704d7d96a7f3f47d060d07cfee06a72f9106...w18_MDL-19071_m23_unicode
          Pull Master Branch w18_MDL-19071_m23_unicode
          Pull from Repository git://github.com/skodak/moodle.git
          Testing Instructions 1/ go to Admin / Server / Environment and verify the result of PCRE unicode test
          2/ find some obsolete install with CentOS 5.5 and test it fails there with warning message, the install is not prevented
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Dan Poltawski made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator poltawski
          Dan Poltawski made changes -
          Testing Instructions 1/ go to Admin / Server / Environment and verify the result of PCRE unicode test
          2/ find some obsolete install with CentOS 5.5 and test it fails there with warning message, the install is not prevented
          1/ go to Admin / Server / Environment and verify that there is a pcreunicode test is present and that is is succeeding (assuming you don't have a buggy install yourself)
          2/ Try a fresh install and verify the same
          3/ With a buggy install (e.g. CentOS 5.5) try an install and test that it is reporting failure with a warning message, the install is not prevented
          Dan Poltawski made changes -
          Labels docs_required triaged,
          Hide
          Dan Poltawski added a comment -

          Thanks Petr that has been integrated now.

          We need some docs on this check at
          http://docs.moodle.org/23/en/admin/environment/pcreunicode

          Helen: Not sure the best way of us managing these additions to docs (we could actually document it in place there since its still relevant to 2.2)

          Show
          Dan Poltawski added a comment - Thanks Petr that has been integrated now. We need some docs on this check at http://docs.moodle.org/23/en/admin/environment/pcreunicode Helen: Not sure the best way of us managing these additions to docs (we could actually document it in place there since its still relevant to 2.2)
          Dan Poltawski made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Michael de Raadt made changes -
          Labels docs_required triaged, docs_required triaged
          Hide
          Helen Foster added a comment -

          If it's also relevant to 2.2, please could someone write a few notes about it here http://docs.moodle.org/22/en/admin/environment/pcreunicode

          Show
          Helen Foster added a comment - If it's also relevant to 2.2, please could someone write a few notes about it here http://docs.moodle.org/22/en/admin/environment/pcreunicode
          Michael de Raadt made changes -
          Tester rajeshtaneja
          Rajesh Taneja made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Rajesh Taneja added a comment -

          Thanks Petr,

          I can see pcreunicode warning, on fresh install and while upgrading on buggy system.

          Passing the test

          Show
          Rajesh Taneja added a comment - Thanks Petr, I can see pcreunicode warning, on fresh install and while upgrading on buggy system. Passing the test
          Rajesh Taneja made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -
          UPDATE tracker_issues
             SET status = 'Closed',
                comment = 'Thanks!'
          WHEN participants = 'Did a gorgeous work'
          

          This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          Show
          Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 04/May/12
          Hide
          Helen Foster added a comment -

          The pcreunicode environment check now has a documentation page:
          http://docs.moodle.org/en/admin/environment/pcreunicode

          Hoping someone can add info to the page or add a comment here explaining what needs adding so I can do it!

          Show
          Helen Foster added a comment - The pcreunicode environment check now has a documentation page: http://docs.moodle.org/en/admin/environment/pcreunicode Hoping someone can add info to the page or add a comment here explaining what needs adding so I can do it!
          Helen Foster made changes -
          Documentation link http://docs.moodle.org/23/en/admin/environment/pcreunicode
          Affects Version/s 2.3 [ 10657 ]
          Helen Foster made changes -
          Summary Look for working unicode regex in environmental cheks Look for working unicode regex in environmental checks
          Documentation link http://docs.moodle.org/23/en/admin/environment/pcreunicode http://docs.moodle.org/en/admin/environment/pcreunicode
          Hide
          Mary Cooch added a comment -

          Jut wondering if anyone has time to add to the documentation page Helen created here: http://docs.moodle.org/25/en/admin/environment/pcreunicode

          Show
          Mary Cooch added a comment - Jut wondering if anyone has time to add to the documentation page Helen created here: http://docs.moodle.org/25/en/admin/environment/pcreunicode
          Petr Škoda made changes -
          Labels docs_required triaged triaged

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: