Import export, so -> Howard in the first instance. If you don't want it Howard, feel free to assign it back to me.

It's fine.... keep 'em coming

I may be assigning this one to Moodle developer job applicants.

Some info to reproduce.

1) Install Moodle and create a course
2) In the course, visit "questions" in the "Course admin" block on the left
3) "Create a new question" of type "Matching".
4) Fill out the first three matched question/answers.
5) Use the "Blanks for more choices" button to get some more form fields
6) Add answers for these extra ones, not questions.
7) Save the quesiton.
8) Go to the "Export" tab, and export as "XHTML" format, then download and view the .html file

What you will see:

The three "questions", each with a menu to choose from, plus some extra menus.

What it should look like:

Just the first three questions+menus. The extra ones shouldn't be there.

Fair enough... let me know if it falls through otherwise I'll leave it with you.

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.1 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

lqjjLKA0p6

The problem seems to exists judging by testing on qa.moodle.net. Please fix it already...

Thanks for reporting this issue.

We have detected that this issue has been inactive for over a year has been recorded as affecting versions that are no longer supported.

If you believe that this issue is still relevant to current versions (2.3 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

Michael d;

4d6f6f646c6521

It still creating those additional controls, tested on qa.moodle.net. The problem remains.

I will fix this bug. XHTML format would need more work but I don't know if it is widely used ?

If more work was to be done on the XHTML format, IMHO what would be interesting would be to create a way for each question type to define a renderer so that this format is extensible to third party question types. Once that is done we could create a quiz report that could "print" a quiz using the same renderers (an often requested feature).

Committed a minimal fix.
When we will be satisfied with master branch I will backport to stable branchs.
But the code of this format is still not up to Moodle standards.
Before creating another tracker issue to do further work on this format, my proposal is to write a message in the quiz forum asking

• who use this export format
• what for they use it (printing question, creating a form to be used outside of Moodle, ...)
• what additional features would be useful

And to decide after looking at the answers what to do with this format.

I forgot to ask peer review !
this can wait as this is a bug fix so better after 2.5 code freeze.

Code change looks good. I think this just needs to be back-ported to stable branches, then we can submit it for integration.

I agree with the fix, its easy enought.

to Jean-Michel on you comment "IMHO what would be interesting would be to create a way for each question type to define a renderer so that this format is extensible to third party question types".

I think that it is quite possible to use existing question renderers for export, using PHP functionality to save HTML output for postprocessing (like http://www.php.net/manual/en/book.outcontrol.php), instead of creating a new ones. As you can see on the moodle.org, I'm project leader on two 3d party question types, by the way.

Hello Tim,
Backported to stable branchs and testing instructions added.
Fix for 23_STABLE is a little different due to differences in code. I don't know if that means it should be tested on that branch too, and if I need to add that precision to testing instructions ?

Integrated to master, 24 and 23.

Thanks, this is an old one!

This is working as expected.

Tested for 2.3, 2.4 and master.

Test passed.

Your awesome contributions are now part of Moodle, your fav LMS out there.

Closing this as fixed.

Many thanks for all the hard work, ciao