Moodle
  1. Moodle
  2. MDL-19092

Workshop password login page incomplete/broken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.6.9+, 1.7.7+, 1.8.9, 1.9.5
    • Component/s: Workshop
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      31723

      Description

      When a user (student) goes to view a workshop with a password, there are a number of errors on the page that is displayed.

      The form isn't closed, incorrect js is used (not compatable with all browsers), if will not function with js turned off, and the page footer is not printed.

      The attached diff should address all those problems.

      I know workshop is getting a major overhall for 2.0, but it would be nice if this fix could make it in for 1.9.5 - I can commit it if there isn't any objection.

      Thanks

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          Eric,

          thanks for the patch. Is JavaScript event onClick needed for the <input> type "submit"? Does it have any special meaning here? I would leave it without JavScript.

          Feel free to commit and assign me as QA.

          TIA

          Show
          David Mudrak added a comment - Eric, thanks for the patch. Is JavaScript event onClick needed for the <input> type "submit"? Does it have any special meaning here? I would leave it without JavScript. Feel free to commit and assign me as QA. TIA
          Hide
          Eric Merrill added a comment -

          Just got rid of the js, since I agree with David that it appears to have no purpose.

          Committed changes to 19, 18, 17, and 16.

          Show
          Eric Merrill added a comment - Just got rid of the js, since I agree with David that it appears to have no purpose. Committed changes to 19, 18, 17, and 16.
          Hide
          David Mudrak added a comment -

          Reviewed. Closing. Thanks Eric!

          Show
          David Mudrak added a comment - Reviewed. Closing. Thanks Eric!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: