Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-19092

Workshop password login page incomplete/broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.4
    • Fix Version/s: 1.6.9+, 1.7.7+, 1.8.9, 1.9.5
    • Component/s: Workshop
    • Labels:
      None
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE

      Description

      When a user (student) goes to view a workshop with a password, there are a number of errors on the page that is displayed.

      The form isn't closed, incorrect js is used (not compatable with all browsers), if will not function with js turned off, and the page footer is not printed.

      The attached diff should address all those problems.

      I know workshop is getting a major overhall for 2.0, but it would be nice if this fix could make it in for 1.9.5 - I can commit it if there isn't any objection.

      Thanks

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                emerrill Eric Merrill
                Reporter:
                emerrill Eric Merrill
                Tester:
                David Mudrák (@mudrd8mz)
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/09